Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Unified Diff: src/js/string.js

Issue 2406873002: [builtins] Move StringEndsWith to a C++ builtin. (Closed)
Patch Set: Use a FlatStringReader instead" Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/builtins/builtins-string.cc ('k') | test/mjsunit/es6/string-endswith.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/js/string.js
diff --git a/src/js/string.js b/src/js/string.js
index e0ee7adef769f28a9499a44642510fa4df84dda3..5d84858d84b38e50965628259b3d68e4c1e58b6b 100644
--- a/src/js/string.js
+++ b/src/js/string.js
@@ -406,33 +406,6 @@ function StringStartsWith(searchString, position) { // length == 1
%FunctionSetLength(StringStartsWith, 1);
-// ES6 draft 04-05-14, section 21.1.3.7
-function StringEndsWith(searchString, position) { // length == 1
- CHECK_OBJECT_COERCIBLE(this, "String.prototype.endsWith");
-
- var s = TO_STRING(this);
-
- if (IsRegExp(searchString)) {
- throw %make_type_error(kFirstArgumentNotRegExp, "String.prototype.endsWith");
- }
-
- var ss = TO_STRING(searchString);
- var s_len = s.length;
- var pos = !IS_UNDEFINED(position) ? TO_INTEGER(position) : s_len
-
- var end = MinSimple(MaxSimple(pos, 0), s_len);
- var ss_len = ss.length;
- var start = end - ss_len;
- if (start < 0) {
- return false;
- }
-
- return %_SubString(s, start, start + ss_len) === ss;
-}
-
-%FunctionSetLength(StringEndsWith, 1);
-
-
// ES6 Draft 05-22-2014, section 21.1.3.3
function StringCodePointAt(pos) {
CHECK_OBJECT_COERCIBLE(this, "String.prototype.codePointAt");
@@ -490,7 +463,6 @@ utils.InstallFunctions(GlobalString, DONT_ENUM, [
utils.InstallFunctions(GlobalString.prototype, DONT_ENUM, [
"codePointAt", StringCodePointAt,
"concat", StringConcat,
- "endsWith", StringEndsWith,
"match", StringMatchJS,
"repeat", StringRepeat,
"replace", StringReplace,
« no previous file with comments | « src/builtins/builtins-string.cc ('k') | test/mjsunit/es6/string-endswith.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698