CustomButton: restrict animation repaints to buttons that actually animate

CustomButton: restrict animation repaints to buttons that actually animate

This change:
1) Adds CustomButton::animates_hover_ and accessors, which governs whether
   a particular button's paint methods depend on animation state;
2) Adds calls to set_animates_hover() in all subclasses that depend on
   the animation state;
3) Adds support in MdTextButton for a hovered state and hover animation.

BUG=650115
Committed: https://crrev.com/ac51b6a1f6c40b0a24a784bc1835f60fb51e8805
Cr-Commit-Position: refs/heads/master@{#425661}

[Elly Fong-Jones, 2016-10-11 14:58:25]

Description was changed from

==========
CustomButton: restrict animation repaints to buttons that actually animate

This change:
1) Adds CustomButton::animates_hover_ and accessors, which governs whether
   a particular button's paint methods depend on animation state;
2) Adds calls to set_animates_hover() in all subclasses that depend on
   the animation state;
3) Adds support in MdTextButton for a hovered state and hover animation.

BUG=650115
==========

to

==========
CustomButton: restrict animation repaints to buttons that actually animate

This change:
1) Adds CustomButton::animates_hover_ and accessors, which governs whether
   a particular button's paint methods depend on animation state;
2) Adds calls to set_animates_hover() in all subclasses that depend on
   the animation state;
3) Adds support in MdTextButton for a hovered state and hover animation.

BUG=650115
==========

[Elly Fong-Jones, 2016-10-11 14:58:25]

ellyjones@chromium.org changed reviewers:
+ sky@chromium.org

[Elly Fong-Jones, 2016-10-11 14:58:31]

sky: ptal? :)

[sky, 2016-10-11 19:17:45]

https://codereview.chromium.org/2406323002/diff/20001/ui/views/controls/butto...
File ui/views/controls/button/custom_button.h (right):

https://codereview.chromium.org/2406323002/diff/20001/ui/views/controls/butto...
ui/views/controls/button/custom_button.h:197: // Whether this button has a hover
effect. If this returns true, painting the
As you mentioned previously, it seems wrong that an animation would be started
and nothing visually changes. This makes me question the usefullness of having
CustomButton have the animation. Is it possible to move the animation entirely
to the subclass? What class is starting an animation but has no visual change
when the animation ticks?

[sky, 2016-10-12 21:48:16]

LGTM

[Elly Fong-Jones, 2016-10-12 21:49:32]

The CQ bit was checked by ellyjones@chromium.org

[commit-bot: I haz the power, 2016-10-12 21:49:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Elly Fong-Jones, 2016-10-12 21:50:04]

The CQ bit was unchecked by ellyjones@chromium.org

[sky, 2016-10-12 21:53:02]

Actually, not lgtm. This is still weird in that the animation is still ticking
even though nothing happens. Can you set animate_on_state_change_ to false and
not add animates_hover_? Maybe animate_on_state_change_ should default to false?

[Elly Fong-Jones, 2016-10-13 12:03:04]

On 2016/10/12 21:53:02, sky wrote:
> Actually, not lgtm. This is still weird in that the animation is still ticking
> even though nothing happens. Can you set animate_on_state_change_ to false and
> not add animates_hover_? Maybe animate_on_state_change_ should default to
false?

Done. ptal? :)

[sky, 2016-10-13 17:45:41]

LGTM

[Elly Fong-Jones, 2016-10-14 15:06:26]

The CQ bit was checked by ellyjones@chromium.org

[commit-bot: I haz the power, 2016-10-14 15:06:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-14 15:43:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-14 15:43:36]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Elly Fong-Jones, 2016-10-17 11:30:32]

The CQ bit was checked by ellyjones@chromium.org

[Elly Fong-Jones, 2016-10-17 11:30:33]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2406323002/#ps60001
(title: "don't use bool(T*)")

[commit-bot: I haz the power, 2016-10-17 11:30:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-17 12:21:09]

Description was changed from

==========
CustomButton: restrict animation repaints to buttons that actually animate

This change:
1) Adds CustomButton::animates_hover_ and accessors, which governs whether
   a particular button's paint methods depend on animation state;
2) Adds calls to set_animates_hover() in all subclasses that depend on
   the animation state;
3) Adds support in MdTextButton for a hovered state and hover animation.

BUG=650115
==========

to

==========
CustomButton: restrict animation repaints to buttons that actually animate

This change:
1) Adds CustomButton::animates_hover_ and accessors, which governs whether
   a particular button's paint methods depend on animation state;
2) Adds calls to set_animates_hover() in all subclasses that depend on
   the animation state;
3) Adds support in MdTextButton for a hovered state and hover animation.

BUG=650115
==========

[commit-bot: I haz the power, 2016-10-17 12:21:09]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-10-17 12:22:53]

Description was changed from

==========
CustomButton: restrict animation repaints to buttons that actually animate

This change:
1) Adds CustomButton::animates_hover_ and accessors, which governs whether
   a particular button's paint methods depend on animation state;
2) Adds calls to set_animates_hover() in all subclasses that depend on
   the animation state;
3) Adds support in MdTextButton for a hovered state and hover animation.

BUG=650115
==========

to

==========
CustomButton: restrict animation repaints to buttons that actually animate

This change:
1) Adds CustomButton::animates_hover_ and accessors, which governs whether
   a particular button's paint methods depend on animation state;
2) Adds calls to set_animates_hover() in all subclasses that depend on
   the animation state;
3) Adds support in MdTextButton for a hovered state and hover animation.

BUG=650115

Committed: https://crrev.com/ac51b6a1f6c40b0a24a784bc1835f60fb51e8805
Cr-Commit-Position: refs/heads/master@{#425661}
==========

[commit-bot: I haz the power, 2016-10-17 12:22:54]

Patchset 4 (id:??) landed as
https://crrev.com/ac51b6a1f6c40b0a24a784bc1835f60fb51e8805
Cr-Commit-Position: refs/heads/master@{#425661}