CustomButton: restrict animation repaints to buttons that actually animate

ui/views/controls/button/custom_button.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/controls/button/custom_button.h"
 
 #include "ui/accessibility/ax_view_state.h"
 #include "ui/events/event.h"
 #include "ui/events/event_utils.h"
 #include "ui/events/keycodes/keyboard_codes.h"
@@ skipping 76 matching lines @@
       hover_animation_.Reset(1);
     }
   }
 
   state_ = state;
   StateChanged();
   SchedulePaint();
 }
 
 void CustomButton::StartThrobbing(int cycles_til_stop) {
+  if (!animate_on_state_change_)
+    return;
   is_throbbing_ = true;
   hover_animation_.StartThrobbing(cycles_til_stop);
 }
 
 void CustomButton::StopThrobbing() {
   if (hover_animation_.is_animating()) {
     hover_animation_.Stop();
     SchedulePaint();
   }
 }
@@ skipping 289 matching lines @@
   return true;
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // CustomButton, protected:
 
 CustomButton::CustomButton(ButtonListener* listener)
     : Button(listener),
       state_(STATE_NORMAL),
       hover_animation_(this),
-      animate_on_state_change_(true),
       is_throbbing_(false),
       triggerable_event_flags_(ui::EF_LEFT_MOUSE_BUTTON),
       request_focus_on_press_(false),
       notify_action_(NOTIFY_ON_RELEASE),
       has_ink_drop_action_on_click_(false),
       hide_ink_drop_when_showing_context_menu_(true),
       ink_drop_base_color_(gfx::kPlaceholderColor) {
   hover_animation_.SetSlideDuration(kHoverFadeDurationMs);
 }
 
@@ skipping 56 matching lines @@
           views::InkDropState::ACTION_PENDING ||
       ink_drop()->GetTargetInkDropState() ==
           views::InkDropState::ALTERNATE_ACTION_PENDING) {
     AnimateInkDrop(views::InkDropState::HIDDEN,
                    ui::LocatedEvent::FromIfValid(&event));
   }
   Button::OnClickCanceled(event);
 }
 
 }  // namespace views