chrome/browser/ui/views/tabs/tab_strip.cc - Issue 2406323002: CustomButton: restrict animation repaints to buttons that actually animate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/tabs/tab_strip.cc

Issue 2406323002: CustomButton: restrict animation repaints to buttons that actually animate (Closed)

Patch Set: don't use bool(T*) Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/tabs/tab_strip.cc

diff --git a/chrome/browser/ui/views/tabs/tab_strip.cc b/chrome/browser/ui/views/tabs/tab_strip.cc

index 2e1530cc7072e343fa670227243eedfdbef53903..8ebceb6bfc69d8656ea477f7a47c8dbe840fa8c2 100644

--- a/chrome/browser/ui/views/tabs/tab_strip.cc

+++ b/chrome/browser/ui/views/tabs/tab_strip.cc

@@ -322,6 +322,7 @@ NewTabButton::NewTabButton(TabStrip* tab_strip, views::ButtonListener* listener)

: views::ImageButton(listener),

tab_strip_(tab_strip),

destroyed_(NULL) {

+ set_animate_on_state_change(true);

#if defined(OS_LINUX) && !defined(OS_CHROMEOS)

set_triggerable_event_flags(triggerable_event_flags() |

ui::EF_MIDDLE_MOUSE_BUTTON);