Added blimp support strings.

Added blimp support strings.

Previously we use 0.5 strings in //blimp/client/app, which are also java
strings generated from a grd file.

This CL port some of the strings into //blimp/client/support/resources.
The embedder may depend on this to access blimp external strings.

The grd file for support strings will only generate strings used in
native code.

There will be another grd file for blimp internal only strings.

BUG=630687
Committed: https://crrev.com/12f1340436b88c4d91355935bea8bdbfb28a58cf
Cr-Commit-Position: refs/heads/master@{#426001}

[xingliu, 2016-10-11 22:11:09]

The CQ bit was checked by xingliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-11 22:11:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-11 22:24:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-11 22:24:14]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[xingliu, 2016-10-11 22:54:28]

xingliu@chromium.org changed reviewers:
+ dtrainor@chromium.org, nyquist@chromium.org

[xingliu, 2016-10-11 22:54:29]

Support string resources setup.

The support string is pretty straight forward that doesn't have GN tricks.

the following is a link to a doc describing the dependency details.

https://docs.google.com/a/google.com/document/d/1V6cxpjdFMkQDwmaKyw7yiqTGuzx2...

[David Trainor- moved to gerrit, 2016-10-13 03:59:34]

lgtm % nits.

https://codereview.chromium.org/2406203003/diff/1/blimp/client/support/resour...
File blimp/client/support/resources/BUILD.gn (right):

https://codereview.chromium.org/2406203003/diff/1/blimp/client/support/resour...
blimp/client/support/resources/BUILD.gn:28: grit("blimp_strings") {
just "strings"?  The target will be "//blimp/client/support:strings" which seems
cleaner :).

https://codereview.chromium.org/2406203003/diff/1/blimp/client/support/resour...
blimp/client/support/resources/BUILD.gn:31: "//chrome/*",
If we're exposing this to an embedder just remove visibility.

https://codereview.chromium.org/2406203003/diff/1/chrome/browser/android/blim...
File chrome/browser/android/blimp/chrome_blimp_client_context_delegate.cc
(right):

https://codereview.chromium.org/2406203003/diff/1/chrome/browser/android/blim...
chrome/browser/android/blimp/chrome_blimp_client_context_delegate.cc:93:
base::string16 disconnected_str = l10n_util::GetStringFUTF16(
Eh just inline this like the OnConnected string.  Maybe add a helper method in
blimp_strings.h to do the prefix for you?

blimp::strings::BlimpPrefix(const base::string16& str);

wdyt?

[xingliu, 2016-10-13 17:51:33]

The CQ bit was checked by xingliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 17:51:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xingliu, 2016-10-13 18:00:56]

xingliu@chromium.org changed reviewers:
+ jshin@chromium.org, thestig@chromium.org

[xingliu, 2016-10-13 18:00:58]

@jshin: please help review change in 
blimp/client/DEPS.

@thestig: please help review change in 
tools/gritsettings/resource_ids
tools/gritsettings/translation_expectations.pyl,

also, we are trying to split one grd file into two, and the xtb translation
files are copied from the original grd file.
Not sure if this is Ok for the localization flow.

https://codereview.chromium.org/2406203003/diff/1/blimp/client/support/resour...
File blimp/client/support/resources/BUILD.gn (right):

https://codereview.chromium.org/2406203003/diff/1/blimp/client/support/resour...
blimp/client/support/resources/BUILD.gn:28: grit("blimp_strings") {
On 2016/10/13 03:59:34, David Trainor wrote:
> just "strings"?  The target will be "//blimp/client/support:strings" which
seems
> cleaner :).

Done.

https://codereview.chromium.org/2406203003/diff/1/blimp/client/support/resour...
blimp/client/support/resources/BUILD.gn:31: "//chrome/*",
On 2016/10/13 03:59:34, David Trainor wrote:
> If we're exposing this to an embedder just remove visibility.

Done.

https://codereview.chromium.org/2406203003/diff/1/chrome/browser/android/blim...
File chrome/browser/android/blimp/chrome_blimp_client_context_delegate.cc
(right):

https://codereview.chromium.org/2406203003/diff/1/chrome/browser/android/blim...
chrome/browser/android/blimp/chrome_blimp_client_context_delegate.cc:93:
base::string16 disconnected_str = l10n_util::GetStringFUTF16(
On 2016/10/13 03:59:34, David Trainor wrote:
> Eh just inline this like the OnConnected string.  Maybe add a helper method in
> blimp_strings.h to do the prefix for you?
> 
> blimp::strings::BlimpPrefix(const base::string16& str);
> 
> wdyt?
Makes sense.

[Lei Zhang, 2016-10-13 18:09:48]

https://codereview.chromium.org/2406203003/diff/40001/blimp/client/DEPS
File blimp/client/DEPS (right):

https://codereview.chromium.org/2406203003/diff/40001/blimp/client/DEPS#newco...
blimp/client/DEPS:18: "+ui/base/l10n",
alphabetical order please

https://codereview.chromium.org/2406203003/diff/40001/blimp/client/support/re...
File blimp/client/support/resources/blimp_strings.grd (right):

https://codereview.chromium.org/2406203003/diff/40001/blimp/client/support/re...
blimp/client/support/resources/blimp_strings.grd:21: <if expr="is_ios">
Does this ever eval to true? Blimp is Android-only, right?

https://codereview.chromium.org/2406203003/diff/40001/blimp/client/support/re...
File blimp/client/support/resources/blimp_strings.h (right):

https://codereview.chromium.org/2406203003/diff/40001/blimp/client/support/re...
blimp/client/support/resources/blimp_strings.h:18: base::string16
BlimpPrefix(const base::string16& str) {
Is there a bot that builds this with clang + clang's chromium style plugin? I
wonder if it will like this being inlined.

https://codereview.chromium.org/2406203003/diff/40001/chrome/browser/android/...
File chrome/browser/android/DEPS (right):

https://codereview.chromium.org/2406203003/diff/40001/chrome/browser/android/...
chrome/browser/android/DEPS:3: "+blimp/client/support/resources",
I'm curious, this is for blimp/client/support/resources/blimp_strings.h	right?
Why not put the header in b/c/public?

[commit-bot: I haz the power, 2016-10-13 19:04:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-13 19:04:26]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[xingliu, 2016-10-13 20:22:28]

The CQ bit was checked by xingliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 20:22:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xingliu, 2016-10-13 20:55:00]

The CQ bit was checked by xingliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 20:55:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xingliu, 2016-10-13 21:00:14]

Thanks for the feedback, please help to take a look.

https://codereview.chromium.org/2406203003/diff/1/chrome/browser/android/blim...
File chrome/browser/android/blimp/chrome_blimp_client_context_delegate.cc
(right):

https://codereview.chromium.org/2406203003/diff/1/chrome/browser/android/blim...
chrome/browser/android/blimp/chrome_blimp_client_context_delegate.cc:93:
base::string16 disconnected_str = l10n_util::GetStringFUTF16(
On 2016/10/13 18:00:58, xingliu wrote:
> On 2016/10/13 03:59:34, David Trainor wrote:
> > Eh just inline this like the OnConnected string.  Maybe add a helper method
in
> > blimp_strings.h to do the prefix for you?
> > 
> > blimp::strings::BlimpPrefix(const base::string16& str);
> > 
> > wdyt?
> Makes sense.

https://codereview.chromium.org/2406203003/diff/40001/blimp/client/DEPS
File blimp/client/DEPS (right):

https://codereview.chromium.org/2406203003/diff/40001/blimp/client/DEPS#newco...
blimp/client/DEPS:18: "+ui/base/l10n",
On 2016/10/13 18:09:48, Lei Zhang wrote:
> alphabetical order please

Done.

https://codereview.chromium.org/2406203003/diff/40001/blimp/client/support/re...
File blimp/client/support/resources/blimp_strings.grd (right):

https://codereview.chromium.org/2406203003/diff/40001/blimp/client/support/re...
blimp/client/support/resources/blimp_strings.grd:21: <if expr="is_ios">
On 2016/10/13 18:09:48, Lei Zhang wrote:
> Does this ever eval to true? Blimp is Android-only, right?

Yeah, I'll remove this.

https://codereview.chromium.org/2406203003/diff/40001/blimp/client/support/re...
File blimp/client/support/resources/blimp_strings.h (right):

https://codereview.chromium.org/2406203003/diff/40001/blimp/client/support/re...
blimp/client/support/resources/blimp_strings.h:18: base::string16
BlimpPrefix(const base::string16& str) {
On 2016/10/13 18:09:48, Lei Zhang wrote:
> Is there a bot that builds this with clang + clang's chromium style plugin? I
> wonder if it will like this being inlined.

Moved this into cc file.

https://codereview.chromium.org/2406203003/diff/40001/chrome/browser/android/...
File chrome/browser/android/DEPS (right):

https://codereview.chromium.org/2406203003/diff/40001/chrome/browser/android/...
chrome/browser/android/DEPS:3: "+blimp/client/support/resources",
On 2016/10/13 18:09:48, Lei Zhang wrote:
> I'm curious, this is for blimp/client/support/resources/blimp_strings.h	right?
> Why not put the header in b/c/public?

Support strings is optional for the embedder. 

There will be another CL setup resources in public.

[Lei Zhang, 2016-10-13 21:08:46]

The red trybots from patch set 3 makes me think there's still some (missing)
dependency issue.

https://codereview.chromium.org/2406203003/diff/80001/chrome/chrome_repack_lo...
File chrome/chrome_repack_locales.gni (right):

https://codereview.chromium.org/2406203003/diff/80001/chrome/chrome_repack_lo...
chrome/chrome_repack_locales.gni:59:
"${root_gen_dir}/blimp/client/support/resources/blimp_strings_",
Should the newly added lines be in an Android only section?

[xingliu, 2016-10-13 21:15:14]

On 2016/10/13 21:08:46, Lei Zhang wrote:
> The red trybots from patch set 3 makes me think there's still some (missing)
> dependency issue.
> 
>
https://codereview.chromium.org/2406203003/diff/80001/chrome/chrome_repack_lo...
> File chrome/chrome_repack_locales.gni (right):
> 
>
https://codereview.chromium.org/2406203003/diff/80001/chrome/chrome_repack_lo...
> chrome/chrome_repack_locales.gni:59:
> "${root_gen_dir}/blimp/client/support/resources/blimp_strings_",
> Should the newly added lines be in an Android only section?

Yes, I fixed a dependency issue in chrome/browser/BUILD.gn. Found the
blimp_strings.cc didn't link.

[xingliu, 2016-10-13 21:23:29]

https://codereview.chromium.org/2406203003/diff/80001/chrome/chrome_repack_lo...
File chrome/chrome_repack_locales.gni (right):

https://codereview.chromium.org/2406203003/diff/80001/chrome/chrome_repack_lo...
chrome/chrome_repack_locales.gni:59:
"${root_gen_dir}/blimp/client/support/resources/blimp_strings_",
On 2016/10/13 21:08:45, Lei Zhang wrote:
> Should the newly added lines be in an Android only section?

I think we're trying to make Blimp platform agnostic.

So the string access is from native layer, and thus we also put the resources
here.

[Lei Zhang, 2016-10-13 21:31:41]

https://codereview.chromium.org/2406203003/diff/80001/chrome/chrome_repack_lo...
File chrome/chrome_repack_locales.gni (right):

https://codereview.chromium.org/2406203003/diff/80001/chrome/chrome_repack_lo...
chrome/chrome_repack_locales.gni:59:
"${root_gen_dir}/blimp/client/support/resources/blimp_strings_",
On 2016/10/13 21:23:29, xingliu wrote:
> On 2016/10/13 21:08:45, Lei Zhang wrote:
> > Should the newly added lines be in an Android only section?
> 
> I think we're trying to make Blimp platform agnostic.
> 
> So the string access is from native layer, and thus we also put the resources
> here.

So I asked if Blimp is Android-only earlier. I the answer now is all platforms
but iOS? Final answer?

[xingliu, 2016-10-13 21:38:01]

On 2016/10/13 21:23:29, xingliu wrote:
>
https://codereview.chromium.org/2406203003/diff/80001/chrome/chrome_repack_lo...
> File chrome/chrome_repack_locales.gni (right):
> 
>
https://codereview.chromium.org/2406203003/diff/80001/chrome/chrome_repack_lo...
> chrome/chrome_repack_locales.gni:59:
> "${root_gen_dir}/blimp/client/support/resources/blimp_strings_",
> On 2016/10/13 21:08:45, Lei Zhang wrote:
> > Should the newly added lines be in an Android only section?
> 
> I think we're trying to make Blimp platform agnostic.
> 
> So the string access is from native layer, and thus we also put the resources
> here.

Yes.

[Lei Zhang, 2016-10-13 21:40:22]

lgtm

[commit-bot: I haz the power, 2016-10-13 22:26:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-13 22:26:41]

Dry run: This issue passed the CQ dry run.

[xingliu, 2016-10-14 19:20:11]

Thanks for the feedback.

Friendly ping. @jshin

[xingliu, 2016-10-17 16:22:23]

The CQ bit was checked by xingliu@chromium.org

[xingliu, 2016-10-17 16:22:24]

The patchset sent to the CQ was uploaded after l-g-t-m from
dtrainor@chromium.org
Link to the patchset: https://codereview.chromium.org/2406203003/#ps80001
(title: "Removed unused import in GN.")

[commit-bot: I haz the power, 2016-10-17 16:22:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-17 16:33:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-17 16:33:39]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[jungshik at Google, 2016-10-17 20:24:34]

DEPS file change looks good, but I have a question about xtb file changes.

https://codereview.chromium.org/2406203003/diff/80001/blimp/client/support/re...
File blimp/client/support/resources/translations/blimp_strings_am.xtb (left):

https://codereview.chromium.org/2406203003/diff/80001/blimp/client/support/re...
blimp/client/support/resources/translations/blimp_strings_am.xtb:7: <translation
id="1491042665327336022">እባክዎ መተግበሪያውን ዳግም ያስጀምሩ።</translation>
All these xtb changes are intended?  Usually, xtb files are never directly
touched. You update grd files and wait for the translation to come back in xtb
files. 

Am I missing something here?

[xingliu, 2016-10-17 20:49:51]

https://codereview.chromium.org/2406203003/diff/80001/blimp/client/support/re...
File blimp/client/support/resources/translations/blimp_strings_am.xtb (left):

https://codereview.chromium.org/2406203003/diff/80001/blimp/client/support/re...
blimp/client/support/resources/translations/blimp_strings_am.xtb:7: <translation
id="1491042665327336022">እባክዎ መተግበሪያውን ዳግም ያስጀምሩ።</translation>
On 2016/10/17 20:24:34, jungshik at google wrote:
> All these xtb changes are intended?  Usually, xtb files are never directly
> touched. You update grd files and wait for the translation to come back in xtb
> files. 
> 
> Am I missing something here?
> 
Thanks for the feedback,

These xtb files are copied from another grd file's translation directory, since
we are splitting that grd file into two.

I guess the diff here is caused by the original grd translation are updated,
then the copy overs didn't catch the new updates.

Not sure what is the best thing to do here, I can redo the copy to let them
matched up, or provide empty files here according to localization
documentation(but translation efforts will be lost). wdyt?

[xingliu, 2016-10-17 23:36:53]

The CQ bit was checked by xingliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-17 23:37:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jungshik at Google, 2016-10-17 23:57:02]

On 2016/10/17 20:49:51, xingliu wrote:
>
https://codereview.chromium.org/2406203003/diff/80001/blimp/client/support/re...
> File blimp/client/support/resources/translations/blimp_strings_am.xtb (left):
> 
>
https://codereview.chromium.org/2406203003/diff/80001/blimp/client/support/re...
> blimp/client/support/resources/translations/blimp_strings_am.xtb:7:
<translation
> id="1491042665327336022">እባክዎ መተግበሪያውን ዳግም ያስጀምሩ።</translation>
> On 2016/10/17 20:24:34, jungshik at google wrote:
> > All these xtb changes are intended?  Usually, xtb files are never directly
> > touched. You update grd files and wait for the translation to come back in
xtb
> > files. 
> > 
> > Am I missing something here?
> > 
> Thanks for the feedback,
> 
> These xtb files are copied from another grd file's translation directory,
since
> we are splitting that grd file into two.
> 
> I guess the diff here is caused by the original grd translation are updated,
> then the copy overs didn't catch the new updates.
> 
> Not sure what is the best thing to do here, I can redo the copy to let them
> matched up, or provide empty files here according to localization
> documentation(but translation efforts will be lost). wdyt?

The message IDs are calculated by 'original message'(usually in English) and
'meaning' field in grd. 'meaning' field is usually absent. So, msg ids are soley
determined by 'original messages in English. So, I guess these messages won't be
retranslated as long as they are a part of the same TC project.  

So, either way (copying over an up-to-date xtb files) or putting in an empty xtb
files should work, I believe.

[xingliu, 2016-10-18 00:28:06]

On 2016/10/17 23:57:02, jungshik at google wrote:
> On 2016/10/17 20:49:51, xingliu wrote:
> >
>
https://codereview.chromium.org/2406203003/diff/80001/blimp/client/support/re...
> > File blimp/client/support/resources/translations/blimp_strings_am.xtb
(left):
> > 
> >
>
https://codereview.chromium.org/2406203003/diff/80001/blimp/client/support/re...
> > blimp/client/support/resources/translations/blimp_strings_am.xtb:7:
> <translation
> > id="1491042665327336022">እባክዎ መተግበሪያውን ዳግም ያስጀምሩ።</translation>
> > On 2016/10/17 20:24:34, jungshik at google wrote:
> > > All these xtb changes are intended?  Usually, xtb files are never directly
> > > touched. You update grd files and wait for the translation to come back in
> xtb
> > > files. 
> > > 
> > > Am I missing something here?
> > > 
> > Thanks for the feedback,
> > 
> > These xtb files are copied from another grd file's translation directory,
> since
> > we are splitting that grd file into two.
> > 
> > I guess the diff here is caused by the original grd translation are updated,
> > then the copy overs didn't catch the new updates.
> > 
> > Not sure what is the best thing to do here, I can redo the copy to let them
> > matched up, or provide empty files here according to localization
> > documentation(but translation efforts will be lost). wdyt?
> 
> The message IDs are calculated by 'original message'(usually in English) and
> 'meaning' field in grd. 'meaning' field is usually absent. So, msg ids are
soley
> determined by 'original messages in English. So, I guess these messages won't
be
> retranslated as long as they are a part of the same TC project.  
> 
> So, either way (copying over an up-to-date xtb files) or putting in an empty
xtb
> files should work, I believe.

Thanks, just updated all the xtb files to empty stubs, please help to take a
look.

[commit-bot: I haz the power, 2016-10-18 01:13:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-18 01:13:26]

Dry run: This issue passed the CQ dry run.

[jungshik at Google, 2016-10-18 17:01:11]

LGTM !

[xingliu, 2016-10-18 17:13:38]

The CQ bit was checked by xingliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-18 17:14:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-18 17:19:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-18 17:19:26]

Dry run: This issue passed the CQ dry run.

[xingliu, 2016-10-18 17:20:01]

The CQ bit was checked by xingliu@chromium.org

[xingliu, 2016-10-18 17:20:01]

The patchset sent to the CQ was uploaded after l-g-t-m from
thestig@chromium.org, dtrainor@chromium.org
Link to the patchset: https://codereview.chromium.org/2406203003/#ps100001
(title: "Use empty translation file stubs.")

[commit-bot: I haz the power, 2016-10-18 17:20:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-18 17:26:47]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-10-18 17:28:57]

Description was changed from

==========
Added blimp support strings.

Previously we use 0.5 strings in //blimp/client/app, which are also java
strings generated from a grd file.

This CL port some of the strings into //blimp/client/support/resources.
The embedder may depend on this to access blimp external strings.

The grd file for support strings will only generate strings used in
native code.

There will be another grd file for blimp internal only strings.


BUG=630687
==========

to

==========
Added blimp support strings.

Previously we use 0.5 strings in //blimp/client/app, which are also java
strings generated from a grd file.

This CL port some of the strings into //blimp/client/support/resources.
The embedder may depend on this to access blimp external strings.

The grd file for support strings will only generate strings used in
native code.

There will be another grd file for blimp internal only strings.

BUG=630687

Committed: https://crrev.com/12f1340436b88c4d91355935bea8bdbfb28a58cf
Cr-Commit-Position: refs/heads/master@{#426001}
==========

[commit-bot: I haz the power, 2016-10-18 17:28:59]

Patchset 6 (id:??) landed as
https://crrev.com/12f1340436b88c4d91355935bea8bdbfb28a58cf
Cr-Commit-Position: refs/heads/master@{#426001}