Chromium Code Reviews
DescriptionChange Rietveld.latest_try_jobs to return try job result details.
In this CL:
- Make latest_try_jobs return a dict mapping builds to result dicts
and return that instead of just a list of builds.
- Move and refactor filter_latest_builds and mark as protected.
- Remove unused method get_latest_try_job_results.
- Update tests and other callers.
Reason: In order to make rebaseline-cl not start new try jobs for
builders that already have try jobs started (http://crbug.com/654919),
we need access to the current try job state/result information.
Possible changes to consider before submitting:
- Maybe we don't want to pass on the result dicts from rietveld as-is,
but perhaps instead we just want to return a couple pieces of
information about the job (e.g. is it started? is it finished?)
BUG=654919
Committed: https://crrev.com/6b2243fab21e96c0cb75fc342a7a49ea7274f9d0
Cr-Commit-Position: refs/heads/master@{#424761}
Patch Set 1 #
Messages
Total messages: 12 (7 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||