Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issue 2406153003: Change Rietveld.latest_try_jobs to return try job result details. (Closed)

Created:
4 years, 2 months ago by qyearsley
Modified:
4 years, 2 months ago
Reviewers:
Dirk Pranke, wkorman
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, cbentzel+watch_chromium.org, chromium-reviews, Dirk Pranke, jeffcarp
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change Rietveld.latest_try_jobs to return try job result details. In this CL: - Make latest_try_jobs return a dict mapping builds to result dicts and return that instead of just a list of builds. - Move and refactor filter_latest_builds and mark as protected. - Remove unused method get_latest_try_job_results. - Update tests and other callers. Reason: In order to make rebaseline-cl not start new try jobs for builders that already have try jobs started (http://crbug.com/654919), we need access to the current try job state/result information. Possible changes to consider before submitting: - Maybe we don't want to pass on the result dicts from rietveld as-is, but perhaps instead we just want to return a couple pieces of information about the job (e.g. is it started? is it finished?) BUG=654919 Committed: https://crrev.com/6b2243fab21e96c0cb75fc342a7a49ea7274f9d0 Cr-Commit-Position: refs/heads/master@{#424761}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -75 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/common/net/rietveld.py View 3 chunks +40 lines, -43 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/net/rietveld_unittest.py View 3 chunks +24 lines, -22 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/update_w3c_test_expectations.py View 1 chunk +5 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
qyearsley
4 years, 2 months ago (2016-10-11 23:28:43 UTC) #2
Dirk Pranke
lgtm
4 years, 2 months ago (2016-10-11 23:39:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2406153003/1
4 years, 2 months ago (2016-10-12 16:28:09 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-12 16:33:58 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 16:37:12 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6b2243fab21e96c0cb75fc342a7a49ea7274f9d0
Cr-Commit-Position: refs/heads/master@{#424761}

Powered by Google App Engine
This is Rietveld 408576698