Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py

Issue 2406153003: Change Rietveld.latest_try_jobs to return try job result details. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py
index 01d1b532263b4b50af1c3422ef1166cac8470ed7..74cdd52504e672cac908cfea45de9dd8d5cf062b 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py
@@ -56,7 +56,7 @@ class RebaselineCL(AbstractParallelRebaselineCommand):
if not issue_number:
return
- builds = self.rietveld.latest_try_jobs(issue_number, self._try_bots())
+ builds = self.rietveld.latest_try_job_results(issue_number, self._try_bots())
if options.trigger_jobs:
if self.trigger_jobs_for_missing_builds(builds):
_log.info('Please re-run webkit-patch rebaseline-cl once all pending try jobs have finished.')
@@ -163,10 +163,10 @@ class RebaselineCL(AbstractParallelRebaselineCommand):
def _builds_to_tests(self, issue_number):
"""Fetches a list of try bots, and for each, fetches tests with new baselines."""
_log.debug('Getting results for Rietveld issue %d.', issue_number)
- try_jobs = self.rietveld.latest_try_jobs(issue_number, self._try_bots())
- if not try_jobs:
+ builds = self.rietveld.latest_try_job_results(issue_number, self._try_bots())
+ if not builds:
_log.debug('No try job results for builders in: %r.', self._try_bots())
- return {build: self._tests_to_rebaseline(build) for build in try_jobs}
+ return {build: self._tests_to_rebaseline(build) for build in builds}
def _try_bots(self):
"""Returns a collection of try bot builders to fetch results for."""

Powered by Google App Engine
This is Rietveld 408576698