Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(626)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/w3c/update_w3c_test_expectations.py

Issue 2406153003: Change Rietveld.latest_try_jobs to return try job result details. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Tools/Scripts/webkitpy/w3c/update_w3c_test_expectations.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/update_w3c_test_expectations.py b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/update_w3c_test_expectations.py
index d5822028ee88fb02435cfe4158288a4ac1928baa..1149d25bcbef30a93338d63cf6ea6d7a2cb4da3c 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/update_w3c_test_expectations.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/update_w3c_test_expectations.py
@@ -43,18 +43,17 @@ class W3CExpectationsLineAdder(object):
_log.error('No issue on current branch.')
return 1
- try_bots = self.get_try_bots()
rietveld = Rietveld(self.host.web)
- try_jobs = rietveld.latest_try_jobs(issue_number, try_bots)
- _log.debug('Latest try jobs: %r', try_jobs)
+ builds = rietveld.latest_try_job_results(issue_number, self.get_try_bots())
+ _log.debug('Latest try jobs: %r', builds)
- if not try_jobs:
+ if not builds:
_log.error('No try job information was collected.')
return 1
test_expectations = {}
- for job in try_jobs:
- platform_results = self.get_failing_results_dict(job)
+ for build in builds:
+ platform_results = self.get_failing_results_dict(build)
test_expectations = self.merge_dicts(test_expectations, platform_results)
for test_name, platform_result in test_expectations.iteritems():
« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698