[MD settings] inform users that the spelling service sends data to google

[MD settings] inform users that the spelling service sends data to google

This CL changes the 'use web service for spell checking' checkbox into
a two line toggle button row, with a second line describing how typed
data will be sent to Google servers.

BUG=649050
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/586eee275624cb36ff14109236c8be3928dab2a6
Cr-Commit-Position: refs/heads/master@{#424258}

[dschuyler, 2016-10-08 00:25:37]

Description was changed from

==========
[MD settings] inform users that the spelling service sends data to google

This CL changes the 'use web service for spell checking' checkbox into
a two line toggle button row, with a second line describing how typed
data will be sent to Google servers.

BUG=649050
==========

to

==========
[MD settings] inform users that the spelling service sends data to google

This CL changes the 'use web service for spell checking' checkbox into
a two line toggle button row, with a second line describing how typed
data will be sent to Google servers.

BUG=649050
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dschuyler, 2016-10-08 00:25:40]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-08 00:26:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dschuyler, 2016-10-08 00:28:31]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-08 00:28:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dschuyler, 2016-10-08 00:29:01]

Patchset #1 (id:1) has been deleted

[dschuyler, 2016-10-08 00:29:23]

dschuyler@chromium.org changed reviewers:
+ hcarmona@chromium.org

[dschuyler, 2016-10-08 00:29:24]

https://codereview.chromium.org/2405653002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/privacy_page/privacy_page.html (left):

https://codereview.chromium.org/2405653002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/privacy_page/privacy_page.html:182: <template
is="dom-if" route-path="/siteSettings/automaticDownloads" no-search>
This looks like it was a whoops.
I can move it to a separate CL if preferred.

[commit-bot: I haz the power, 2016-10-08 00:40:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-08 00:40:11]

Dry run: Try jobs failed on following builders:
  closure_compilation on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compila...)

[dschuyler, 2016-10-08 00:42:10]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[dschuyler, 2016-10-08 00:42:21]

Patchset #1 (id:20001) has been deleted

[commit-bot: I haz the power, 2016-10-08 00:42:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-08 00:52:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-08 00:52:36]

Dry run: Try jobs failed on following builders:
  closure_compilation on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compila...)

[hcarmona, 2016-10-08 01:06:59]

https://codereview.chromium.org/2405653002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/privacy_page/privacy_page.html (right):

https://codereview.chromium.org/2405653002/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/privacy_page/privacy_page.html:124:
on-tap="onUseSpellingServiceTap_">
This seems odd to me. Do we have other places where clicking the row
changes the toggle?

https://codereview.chromium.org/2405653002/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/privacy_page/privacy_page.html:129:
<paper-toggle-button id="spellingServiceToggleButton">
If it's not a requirement that the row toggle the toggle button, then
this can be simplified by binding directly to the checked attribute:
checked="{{prefs.spellcheck.use_spelling_service.value}}"

[dschuyler, 2016-10-08 01:31:57]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-08 01:32:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dschuyler, 2016-10-08 01:36:08]

https://codereview.chromium.org/2405653002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/privacy_page/privacy_page.html (right):

https://codereview.chromium.org/2405653002/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/privacy_page/privacy_page.html:124:
on-tap="onUseSpellingServiceTap_">
On 2016/10/08 01:06:59, Hector Carmona wrote:
> This seems odd to me. Do we have other places where clicking the row
> changes the toggle?

Alan had requested that clicking anywhere in the row to take the action
on that row (if the row has one main action, I believe). While I don't
have another example handy, afaik this is the desired behavior.

https://codereview.chromium.org/2405653002/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/privacy_page/privacy_page.html:129:
<paper-toggle-button id="spellingServiceToggleButton">
On 2016/10/08 01:06:59, Hector Carmona wrote:
> If it's not a requirement that the row toggle the toggle button, then
> this can be simplified by binding directly to the checked attribute:
> checked="{{prefs.spellcheck.use_spelling_service.value}}"

That would be simpler, but afaik it's desired by UX, which is like it
being required - unless it's intractable, but it seems like small
alteration (i.e. tractable).

[commit-bot: I haz the power, 2016-10-08 02:37:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-08 02:37:56]

Dry run: This issue passed the CQ dry run.

[hcarmona, 2016-10-10 14:09:29]

LGTM

https://codereview.chromium.org/2405653002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/privacy_page/privacy_page.html (right):

https://codereview.chromium.org/2405653002/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/privacy_page/privacy_page.html:124:
on-tap="onUseSpellingServiceTap_">
On 2016/10/08 01:36:08, dschuyler wrote:
> On 2016/10/08 01:06:59, Hector Carmona wrote:
> > This seems odd to me. Do we have other places where clicking the row
> > changes the toggle?
> 
> Alan had requested that clicking anywhere in the row to take the action
> on that row (if the row has one main action, I believe). While I don't
> have another example handy, afaik this is the desired behavior.

OK, sounds good.

https://codereview.chromium.org/2405653002/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/privacy_page/privacy_page.html:129:
<paper-toggle-button id="spellingServiceToggleButton">
On 2016/10/08 01:36:08, dschuyler wrote:
> On 2016/10/08 01:06:59, Hector Carmona wrote:
> > If it's not a requirement that the row toggle the toggle button, then
> > this can be simplified by binding directly to the checked attribute:
> > checked="{{prefs.spellcheck.use_spelling_service.value}}"
> 
> That would be simpler, but afaik it's desired by UX, which is like it
> being required - unless it's intractable, but it seems like small
> alteration (i.e. tractable).

Acknowledged.

[dschuyler, 2016-10-10 18:31:43]

The CQ bit was checked by dschuyler@chromium.org

[commit-bot: I haz the power, 2016-10-10 18:32:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-10 19:28:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-10 19:28:48]

Failed to apply patch for chrome/app/settings_strings.grdp:
While running git apply --index -3 -p1;
  error: patch failed: chrome/app/settings_strings.grdp:872
  Falling back to three-way merge...
  Applied patch to 'chrome/app/settings_strings.grdp' with conflicts.
  U chrome/app/settings_strings.grdp

Patch:       chrome/app/settings_strings.grdp
Index: chrome/app/settings_strings.grdp
diff --git a/chrome/app/settings_strings.grdp b/chrome/app/settings_strings.grdp
index
984e59657de7516a1f21ed124681cfc984b61a04..ef1d54248150370fa90a723a88a19712a3393483
100644
--- a/chrome/app/settings_strings.grdp
+++ b/chrome/app/settings_strings.grdp
@@ -872,7 +872,7 @@
     </message>
     <message
name="IDS_SETTINGS_PRINTING_CUPS_PRINTER_ADDED_PRINTER_TRY_AGAIN_MESSAGE"
desc="The try-again message shown when a new printer is not set up
successfully.">
       Try again
-    </message>  
+    </message>
   </if>
   <message name="IDS_SETTINGS_PRINTING_CLOUD_PRINTERS" desc="In Printing
Settings, the title of the google cloud printers setting section.">
     Google Cloud Print
@@ -1466,6 +1466,9 @@
   <message name="IDS_SETTINGS_SPELLING_PREF" desc="The documentation string of
the 'Use Spelling' preference">
     Use a web service to help resolve spelling errors
   </message>
+  <message name="IDS_SETTINGS_SPELLING_DESCRIPTION" desc="Description of using
a web serviced to help resolve spelling errors. It is important to convey that
what the user types will be sent to Google.">
+    Smarter spell-checking by sending what you type in the browser to Google
+  </message>
   <message name="IDS_SETTINGS_ENABLE_LOGGING" desc="The label of the checkbox
to enable/disable crash and user metrics logging">
     Automatically send usage statistics and crash reports to Google
   </message>

[dschuyler, 2016-10-10 20:29:03]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-10 20:29:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-10 21:37:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-10 21:37:09]

Dry run: This issue passed the CQ dry run.

[dschuyler, 2016-10-10 22:02:18]

The CQ bit was checked by dschuyler@chromium.org

[dschuyler, 2016-10-10 22:02:19]

The patchset sent to the CQ was uploaded after l-g-t-m from
hcarmona@chromium.org
Link to the patchset: https://codereview.chromium.org/2405653002/#ps80001
(title: "merge with master")

[commit-bot: I haz the power, 2016-10-10 22:02:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-10 22:08:50]

Committed patchset #3 (id:80001)

[commit-bot: I haz the power, 2016-10-10 22:11:50]

Description was changed from

==========
[MD settings] inform users that the spelling service sends data to google

This CL changes the 'use web service for spell checking' checkbox into
a two line toggle button row, with a second line describing how typed
data will be sent to Google servers.

BUG=649050
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD settings] inform users that the spelling service sends data to google

This CL changes the 'use web service for spell checking' checkbox into
a two line toggle button row, with a second line describing how typed
data will be sent to Google servers.

BUG=649050
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/586eee275624cb36ff14109236c8be3928dab2a6
Cr-Commit-Position: refs/heads/master@{#424258}
==========

[commit-bot: I haz the power, 2016-10-10 22:11:52]

Patchset 3 (id:??) landed as
https://crrev.com/586eee275624cb36ff14109236c8be3928dab2a6
Cr-Commit-Position: refs/heads/master@{#424258}