Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Unified Diff: chrome/browser/resources/settings/privacy_page/privacy_page.js

Issue 2405653002: [MD settings] inform users that the spelling service sends data to google (Closed)
Patch Set: merge with master Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/privacy_page/privacy_page.js
diff --git a/chrome/browser/resources/settings/privacy_page/privacy_page.js b/chrome/browser/resources/settings/privacy_page/privacy_page.js
index ebcbff77a4db7b7664a2ef9a02f6c0bdc91a6657..f02f8e1cdfd382491540cab09aaf5f4e1774dd64 100644
--- a/chrome/browser/resources/settings/privacy_page/privacy_page.js
+++ b/chrome/browser/resources/settings/privacy_page/privacy_page.js
@@ -41,9 +41,19 @@ Polymer({
showClearBrowsingDataDialog_: Boolean,
},
+<if expr="_google_chrome">
+ observers: [
+ 'updateSpellingService_(prefs.spellcheck.use_spelling_service.value)',
+ ],
+</if>
+
ready: function() {
this.ContentSettingsTypes = settings.ContentSettingsTypes;
+<if expr="_google_chrome">
+ this.updateSpellingService_();
+</if>
+
<if expr="_google_chrome and not chromeos">
var boundSetMetricsReporting = this.setMetricsReporting_.bind(this);
this.addWebUIListener('metrics-reporting-change', boundSetMetricsReporting);
@@ -101,4 +111,18 @@ Polymer({
this.metricsReporting_ = metricsReporting;
},
</if>
+
+<if expr="_google_chrome">
+ /** @private */
+ updateSpellingService_: function() {
+ this.$.spellingServiceToggleButton.checked =
+ this.get('prefs.spellcheck.use_spelling_service.value');
+ },
+
+ /** @private */
+ onUseSpellingServiceTap_: function() {
+ this.set('prefs.spellcheck.use_spelling_service.value',
+ this.$.spellingServiceToggleButton.checked);
+ },
+</if>
});

Powered by Google App Engine
This is Rietveld 408576698