[MD settings] inform users that the spelling service sends data to google

chrome/browser/resources/settings/privacy_page/privacy_page.html

 <link rel="import" href="chrome://resources/cr_elements/policy/cr_policy_vars_css.html">
 <link rel="import" href="chrome://resources/html/polymer.html">
 <link rel="import" href="chrome://resources/html/web_ui_listener_behavior.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/iron-flex-layout/iron-flex-layout-classes.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/neon-animation/neon-animatable.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-button.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper-icon-button-light.html">
 <link rel="import" href="/clear_browsing_data_dialog/clear_browsing_data_dialog.html">
 <link rel="import" href="/controls/settings_checkbox.html">
 <link rel="import" href="/route.html">
@@ skipping 63 matching lines @@
               hidden="[[!pageVisibility.networkPrediction]]">
           </settings-checkbox>
           <settings-checkbox
               pref="{{prefs.safebrowsing.extended_reporting_enabled}}"
               label="$i18n{safeBrowsingEnableExtendedReporting}">
           </settings-checkbox>
           <settings-checkbox pref="{{prefs.safebrowsing.enabled}}"
               label="$i18n{safeBrowsingEnableProtection}">
           </settings-checkbox>
 <if expr="_google_chrome">
-          <settings-checkbox
-              pref="{{prefs.spellcheck.use_spelling_service}}"
-              label="$i18n{spellingPref}">
-          </settings-checkbox>
 <if expr="chromeos">
           <settings-checkbox
               pref="{{prefs.cros.metrics.reportingEnabled}}"
               label="$i18n{enableLogging}">
           </settings-checkbox>
 </if><!-- chromeos -->
 <if expr="not chromeos">
           <div id="metricsReporting">
             <paper-checkbox id="metricsReportingCheckbox"
                 on-tap="onMetricsReportingCheckboxTap_"
@@ skipping 18 matching lines @@
           <settings-checkbox
               pref="{{prefs.cros.device.attestation_for_content_protection_enabled}}"
               label="$i18n{enableContentProtectionAttestation}">
           </settings-checkbox>
           <settings-checkbox
               pref="{{prefs.settings.internet.wake_on_wifi_darkconnect}}"
               label="$i18n{wakeOnWifi}">
           </settings-checkbox>
 </if>
         </div>
+<if expr="_google_chrome">
+        <div class="settings-box two-line" actionable
+            on-tap="onUseSpellingServiceTap_">

[hcarmona, 2016/10/08 01:06:59]

This seems odd to me. Do we have other places where clicking the row
changes the toggle?

[dschuyler, 2016/10/08 01:36:08]

Alan had requested that clicking anywhere in the row to take the action
on that row (if the row has one main action, I believe). While I don't
have another example handy, afaik this is the desired behavior.

[hcarmona, 2016/10/10 14:09:29]

OK, sounds good.

+          <div class="start">
+            $i18n{spellingPref}
+            <div class="secondary">$i18n{spellingDescription}</div>
+          </div>
+          <paper-toggle-button id="spellingServiceToggleButton">

[hcarmona, 2016/10/08 01:06:59]

If it's not a requirement that the row toggle the toggle button, then
this can be simplified by binding directly to the checked attribute:
checked="{{prefs.spellcheck.use_spelling_service.value}}"

[dschuyler, 2016/10/08 01:36:08]

That would be simpler, but afaik it's desired by UX, which is like it
being required - unless it's intractable, but it seems like small
alteration (i.e. tractable).

[hcarmona, 2016/10/10 14:09:29]

Acknowledged.

+          </paper-toggle-button>
+        </div>
+</if>
 <if expr="use_nss_certs or is_win or is_macosx">
         <div id="manageCertificates" class="settings-box two-line"
             actionable on-tap="onManageCertificatesTap_">
           <div class="start">
             <div>$i18n{manageCertificates}</div>
             <div class="secondary">$i18n{manageCertificatesDescription}</div>
           </div>
           <button class="icon-arrow-right" is="paper-icon-button-light">
           </button>
         </div>
@@ skipping 36 matching lines @@
           <settings-site-settings-page category-selected="{{categorySelected}}">
           </settings-site-settings-page>
         </settings-subpage>
       </template>
 
       <template is="dom-if" route-path="/siteSettings/all" no-search>
         <settings-subpage page-title="$i18n{siteSettingsCategoryAllSites}">
           <all-sites selected-site="{{selectedSite}}"></all-sites>
         </settings-subpage>
       </template>
-      <template is="dom-if" route-path="/siteSettings/automaticDownloads" no-search>
+      <template is="dom-if" route-path="/siteSettings/automaticDownloads"
           no-search>
         <settings-subpage page-title="$i18n{siteSettingsAutomaticDownloads}">
           <site-settings-category
               selected-site="{{selectedSite}}"
               category="{{ContentSettingsTypes.AUTOMATIC_DOWNLOADS}}">
           </site-settings-category>
         </settings-subpage>
       </template>
       <template is="dom-if" route-path="/siteSettings/backgroundSync" no-search>
           no-search>
@@ skipping 97 matching lines @@
         </settings-subpage>
       </template>
       <template is="dom-if" route-path="/siteSettings/popups" no-search>
         <settings-subpage page-title="$i18n{siteSettingsCategoryPopups}">
           <site-settings-category
               selected-site="{{selectedSite}}"
               category="{{ContentSettingsTypes.POPUPS}}">
           </site-settings-category>
         </settings-subpage>
       </template>
-      <template is="dom-if" route-path="/siteSettings/unsandboxedPlugins" no-search>
+      <template is="dom-if" route-path="/siteSettings/unsandboxedPlugins"
+          no-search>
         <settings-subpage page-title="$i18n{siteSettingsUnsandboxedPlugins}">
           <site-settings-category
               selected-site="{{selectedSite}}"
               category="{{ContentSettingsTypes.UNSANDBOXED_PLUGINS}}">
           </site-settings-category>
         </settings-subpage>
       </template>
       <template is="dom-if" route-path="/siteSettings/usbDevices" no-search>
         <settings-subpage page-title="$i18n{siteSettingsUsbDevices}">
           <usb-devices></usb-devices>
         </settings-subpage>
       </template>
       <template is="dom-if" route-path="/siteSettings/siteDetails" no-search>
         <settings-subpage page-title="$i18n{siteSettingsSiteDetails}">
           <site-details site="[[selectedSite]]"></site-details>
         </settings-subpage>
       </template>
     </settings-animated-pages>
   </template>
   <script src="privacy_page.js"></script>
 </dom-module>