Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 24056004: Refactoring: toPluginView and toPluginDocument implemented but not used. (Closed)

Created:
7 years, 3 months ago by r.kasibhatla
Modified:
7 years, 3 months ago
Reviewers:
tkent
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Refactoring: toPluginView and toPluginDocument implemented but not used. Convenience methods toPluginView & toPluginDocument already added but still using the non-preferred static_cast in usage. R=tkent BUG=NONE TEST=None; No behavior change Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157556

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M Source/core/html/HTMLPlugInElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/PluginDocument.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/web/WebFrameImpl.cpp View 1 chunk +1 line, -1 line 1 comment Download
M Source/web/WebPluginDocument.cpp View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 4 (0 generated)
r.kasibhatla
7 years, 3 months ago (2013-09-10 09:45:15 UTC) #1
tkent
lgtm https://codereview.chromium.org/24056004/diff/1/Source/web/WebFrameImpl.cpp File Source/web/WebFrameImpl.cpp (right): https://codereview.chromium.org/24056004/diff/1/Source/web/WebFrameImpl.cpp#newcode281 Source/web/WebFrameImpl.cpp:281: PluginDocument* pluginDocument = toPluginDocument(frame->document()); nit: We can remove ...
7 years, 3 months ago (2013-09-10 21:54:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/r.kasibhatla@samsung.com/24056004/1
7 years, 3 months ago (2013-09-10 21:55:28 UTC) #3
commit-bot: I haz the power
7 years, 3 months ago (2013-09-10 23:01:14 UTC) #4
Message was sent while issue was closed.
Change committed as 157556

Powered by Google App Engine
This is Rietveld 408576698