Source/web/WebFrameImpl.cpp - Issue 24056004: Refactoring: toPluginView and toPluginDocument implemented but not used.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebFrameImpl.cpp

Issue 24056004: Refactoring: toPluginView and toPluginDocument implemented but not used. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/WebFrameImpl.cpp

diff --git a/Source/web/WebFrameImpl.cpp b/Source/web/WebFrameImpl.cpp

index eceb6899bc7fe030dc114d8793b801f48fac98ea..05e1c560c86335768cfc51fd9657dc9fa71e43cb 100644

--- a/Source/web/WebFrameImpl.cpp

+++ b/Source/web/WebFrameImpl.cpp

@@ -278,7 +278,7 @@ WebPluginContainerImpl* WebFrameImpl::pluginContainerFromFrame(Frame* frame)

return 0;

if (!frame->document() || !frame->document()->isPluginDocument())

return 0;

- PluginDocument* pluginDocument = static_cast<PluginDocument*>(frame->document());

+ PluginDocument* pluginDocument = toPluginDocument(frame->document());

tkent 2013/09/10 21:54:51 nit: We can remove a local variable |pluginDocumen

return toPluginContainerImpl(pluginDocument->pluginWidget());

}

« no previous file with comments | « Source/core/html/PluginDocument.cpp ('k') | Source/web/WebPluginDocument.cpp » ('j') | Source/web/WebPluginDocument.cpp » ('J')