Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Side by Side Diff: Source/web/WebPluginDocument.cpp

Issue 24056004: Refactoring: toPluginView and toPluginDocument implemented but not used. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« Source/web/WebFrameImpl.cpp ('K') | « Source/web/WebFrameImpl.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 30 matching lines...) Expand all
41 using namespace WebCore; 41 using namespace WebCore;
42 42
43 namespace WebKit { 43 namespace WebKit {
44 44
45 45
46 WebPlugin* WebPluginDocument::plugin() 46 WebPlugin* WebPluginDocument::plugin()
47 { 47 {
48 if (!isPluginDocument()) 48 if (!isPluginDocument())
49 return 0; 49 return 0;
50 PluginDocument* doc = unwrap<PluginDocument>(); 50 PluginDocument* doc = unwrap<PluginDocument>();
51 WebPluginContainerImpl* container = toPluginContainerImpl(static_cast<Plugin Document*>(doc)->pluginWidget()); 51 WebPluginContainerImpl* container = toPluginContainerImpl(doc->pluginWidget( ));
tkent 2013/09/10 21:54:51 nit: We can remove a local variable |container|.
52 return container->plugin(); 52 return container->plugin();
53 } 53 }
54 54
55 55
56 WebPluginDocument::WebPluginDocument(const PassRefPtr<PluginDocument>& elem) 56 WebPluginDocument::WebPluginDocument(const PassRefPtr<PluginDocument>& elem)
57 : WebDocument(elem) 57 : WebDocument(elem)
58 { 58 {
59 } 59 }
60 60
61 WebPluginDocument& WebPluginDocument::operator=(const PassRefPtr<PluginDocument> & elem) 61 WebPluginDocument& WebPluginDocument::operator=(const PassRefPtr<PluginDocument> & elem)
62 { 62 {
63 m_private = elem; 63 m_private = elem;
64 return *this; 64 return *this;
65 } 65 }
66 66
67 WebPluginDocument::operator PassRefPtr<PluginDocument>() const 67 WebPluginDocument::operator PassRefPtr<PluginDocument>() const
68 { 68 {
69 return static_cast<PluginDocument*>(m_private.get()); 69 return static_cast<PluginDocument*>(m_private.get());
70 } 70 }
71 71
72 } // namespace WebKit 72 } // namespace WebKit
OLDNEW
« Source/web/WebFrameImpl.cpp ('K') | « Source/web/WebFrameImpl.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698