Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 240483008: Revert of [fsp] Add an initial AsyncFileUtil. (Closed)

Created:
6 years, 8 months ago by dconnelly
Modified:
6 years, 8 months ago
Reviewers:
mtomasz, kinaba
CC:
chromium-reviews, nkostylev+watch_chromium.org, tzik, nhiroki, oshima+watch_chromium.org, kinuko+watch, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Revert of [fsp] Add an initial AsyncFileUtil. (https://codereview.chromium.org/236303017/) Reason for revert: Broke Linux Chromium OS Tests -- looks like the new tests aren't working properly there. Failing build: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/30018 Original issue's description: > [fsp] Add an initial AsyncFileUtil. > > This patch adds the AsyncFileUtil implementation for the file system provider. > It does not communicate with the file system provider service yet. > > Currently, for not supported operations SECURITY error is returned. For > allowed, but not implemented operations, it is NOT_FOUND error. > > Unit tests are quite trivial at this stage, but they will grow once more > operations are implemented. > > TEST=unit_test: FileSystemProviderAsyncFileUtilTest* > BUG=248427 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=264462 TBR=kinaba@chromium.org,mtomasz@chromium.org NOTREECHECKS=true NOTRY=true BUG=248427 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=264475

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -808 lines) Patch
M chrome/browser/chrome_content_browser_client.cc View 3 chunks +7 lines, -7 lines 0 comments Download
D chrome/browser/chromeos/file_system_provider/fileapi/backend_delegate.h View 1 chunk +0 lines, -48 lines 0 comments Download
D chrome/browser/chromeos/file_system_provider/fileapi/backend_delegate.cc View 1 chunk +0 lines, -54 lines 0 comments Download
D chrome/browser/chromeos/file_system_provider/fileapi/provider_async_file_util.h View 1 chunk +0 lines, -110 lines 0 comments Download
D chrome/browser/chromeos/file_system_provider/fileapi/provider_async_file_util.cc View 1 chunk +0 lines, -172 lines 0 comments Download
D chrome/browser/chromeos/file_system_provider/fileapi/provider_async_file_util_unittest.cc View 1 chunk +0 lines, -373 lines 0 comments Download
M chrome/browser/chromeos/fileapi/file_system_backend.h View 2 chunks +2 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/fileapi/file_system_backend.cc View 5 chunks +3 lines, -16 lines 0 comments Download
M chrome/browser/chromeos/fileapi/file_system_backend_unittest.cc View 4 chunks +15 lines, -16 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
dconnelly
Created Revert of [fsp] Add an initial AsyncFileUtil.
6 years, 8 months ago (2014-04-17 12:11:31 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dconnelly@chromium.org/240483008/1
6 years, 8 months ago (2014-04-17 12:11:54 UTC) #2
commit-bot: I haz the power
6 years, 8 months ago (2014-04-17 12:12:30 UTC) #3
Message was sent while issue was closed.
Change committed as 264475

Powered by Google App Engine
This is Rietveld 408576698