Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 236303017: [fsp] Add an initial AsyncFileUtil. (Closed)

Created:
6 years, 8 months ago by mtomasz
Modified:
6 years, 8 months ago
Reviewers:
kinaba
CC:
chromium-reviews, nkostylev+watch_chromium.org, tzik, nhiroki, oshima+watch_chromium.org, kinuko+watch, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

[fsp] Add an initial AsyncFileUtil. This patch adds the AsyncFileUtil implementation for the file system provider. It does not communicate with the file system provider service yet. Currently, for not supported operations SECURITY error is returned. For allowed, but not implemented operations, it is NOT_FOUND error. Unit tests are quite trivial at this stage, but they will grow once more operations are implemented. TEST=unit_test: FileSystemProviderAsyncFileUtilTest* BUG=248427 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=264462

Patch Set 1 #

Patch Set 2 : Cleaned up. #

Patch Set 3 : Cleaned up. #

Patch Set 4 : Fixed tests. #

Messages

Total messages: 8 (0 generated)
mtomasz
@kinaba: PTAL. Thanks!
6 years, 8 months ago (2014-04-16 09:17:05 UTC) #1
kinaba
lgtm
6 years, 8 months ago (2014-04-17 05:27:07 UTC) #2
mtomasz
The CQ bit was checked by mtomasz@chromium.org
6 years, 8 months ago (2014-04-17 06:21:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/236303017/40001
6 years, 8 months ago (2014-04-17 06:21:28 UTC) #4
commit-bot: I haz the power
Change committed as 264462
6 years, 8 months ago (2014-04-17 07:48:37 UTC) #5
dconnelly
A revert of this CL has been created in https://codereview.chromium.org/240483008/ by dconnelly@chromium.org. The reason for ...
6 years, 8 months ago (2014-04-17 12:11:31 UTC) #6
mtomasz
On 2014/04/17 12:11:31, dconnelly wrote: > A revert of this CL has been created in ...
6 years, 8 months ago (2014-04-18 01:23:38 UTC) #7
kinaba
6 years, 8 months ago (2014-04-18 03:48:33 UTC) #8
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698