Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Unified Diff: src/isolate.cc

Issue 2404253002: [wasm] Provide better stack traces for asm.js code (Closed)
Patch Set: Address titzer's comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/asmjs/asm-wasm-builder.cc ('k') | src/messages.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/isolate.cc
diff --git a/src/isolate.cc b/src/isolate.cc
index e8329883f7e6eaf44f04ebbccc137e5f106404e1..e3fe381abefd0b5fd636f3dd4e4d1cfbf5517c5f 100644
--- a/src/isolate.cc
+++ b/src/isolate.cc
@@ -520,9 +520,13 @@ Handle<Object> Isolate::CaptureSimpleStackTrace(Handle<JSReceiver> error_object,
DCHECK(wasm::IsWasmObject(*wasm_object) ||
wasm_object->IsUndefined(this));
- elements = FrameArray::AppendWasmFrame(
- elements, wasm_object, wasm_function_index, abstract_code, offset,
- FrameArray::kIsWasmFrame);
+ int flags = wasm::WasmIsAsmJs(*wasm_object, this)
+ ? FrameArray::kIsAsmJsWasmFrame
+ : FrameArray::kIsWasmFrame;
+
+ elements = FrameArray::AppendWasmFrame(elements, wasm_object,
+ wasm_function_index,
+ abstract_code, offset, flags);
} break;
default:
« no previous file with comments | « src/asmjs/asm-wasm-builder.cc ('k') | src/messages.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698