Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Side by Side Diff: src/isolate.cc

Issue 2404253002: [wasm] Provide better stack traces for asm.js code (Closed)
Patch Set: Address titzer's comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/asmjs/asm-wasm-builder.cc ('k') | src/messages.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/isolate.h" 5 #include "src/isolate.h"
6 6
7 #include <stdlib.h> 7 #include <stdlib.h>
8 8
9 #include <fstream> // NOLINT(readability/streams) 9 #include <fstream> // NOLINT(readability/streams)
10 #include <sstream> 10 #include <sstream>
(...skipping 502 matching lines...) Expand 10 before | Expand all | Expand 10 after
513 Code* code = wasm_frame->unchecked_code(); 513 Code* code = wasm_frame->unchecked_code();
514 Handle<AbstractCode> abstract_code(AbstractCode::cast(code), this); 514 Handle<AbstractCode> abstract_code(AbstractCode::cast(code), this);
515 const int offset = 515 const int offset =
516 static_cast<int>(wasm_frame->pc() - code->instruction_start()); 516 static_cast<int>(wasm_frame->pc() - code->instruction_start());
517 517
518 // TODO(wasm): The wasm object returned by the WasmFrame should always 518 // TODO(wasm): The wasm object returned by the WasmFrame should always
519 // be a wasm object. 519 // be a wasm object.
520 DCHECK(wasm::IsWasmObject(*wasm_object) || 520 DCHECK(wasm::IsWasmObject(*wasm_object) ||
521 wasm_object->IsUndefined(this)); 521 wasm_object->IsUndefined(this));
522 522
523 elements = FrameArray::AppendWasmFrame( 523 int flags = wasm::WasmIsAsmJs(*wasm_object, this)
524 elements, wasm_object, wasm_function_index, abstract_code, offset, 524 ? FrameArray::kIsAsmJsWasmFrame
525 FrameArray::kIsWasmFrame); 525 : FrameArray::kIsWasmFrame;
526
527 elements = FrameArray::AppendWasmFrame(elements, wasm_object,
528 wasm_function_index,
529 abstract_code, offset, flags);
526 } break; 530 } break;
527 531
528 default: 532 default:
529 break; 533 break;
530 } 534 }
531 } 535 }
532 536
533 elements->ShrinkToFit(); 537 elements->ShrinkToFit();
534 538
535 // TODO(yangguo): Queue this structured stack trace for preprocessing on GC. 539 // TODO(yangguo): Queue this structured stack trace for preprocessing on GC.
(...skipping 2841 matching lines...) Expand 10 before | Expand all | Expand 10 after
3377 // Then check whether this scope intercepts. 3381 // Then check whether this scope intercepts.
3378 if ((flag & intercept_mask_)) { 3382 if ((flag & intercept_mask_)) {
3379 intercepted_flags_ |= flag; 3383 intercepted_flags_ |= flag;
3380 return true; 3384 return true;
3381 } 3385 }
3382 return false; 3386 return false;
3383 } 3387 }
3384 3388
3385 } // namespace internal 3389 } // namespace internal
3386 } // namespace v8 3390 } // namespace v8
OLDNEW
« no previous file with comments | « src/asmjs/asm-wasm-builder.cc ('k') | src/messages.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698