Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(739)

Unified Diff: src/messages.h

Issue 2404253002: [wasm] Provide better stack traces for asm.js code (Closed)
Patch Set: Address titzer's comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/isolate.cc ('k') | src/messages.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/messages.h
diff --git a/src/messages.h b/src/messages.h
index e7bbcc34c2391af25586b557b81ed03dfe434fb6..a1994f6b59adb185eee89fa361f69622f1910ed4 100644
--- a/src/messages.h
+++ b/src/messages.h
@@ -148,8 +148,7 @@ class WasmStackFrame : public StackFrameBase {
MaybeHandle<String> ToString() override;
- private:
- void FromFrameArray(Isolate* isolate, Handle<FrameArray> array, int frame_ix);
+ protected:
Handle<Object> Null() const;
Isolate* isolate_;
@@ -159,9 +158,30 @@ class WasmStackFrame : public StackFrameBase {
Handle<AbstractCode> code_;
int offset_;
+ private:
+ void FromFrameArray(Isolate* isolate, Handle<FrameArray> array, int frame_ix);
+
friend class FrameArrayIterator;
};
+class AsmJsWasmStackFrame : public WasmStackFrame {
+ public:
+ virtual ~AsmJsWasmStackFrame() {}
+
+ Handle<Object> GetReceiver() const override;
+ Handle<Object> GetFunction() const override;
+
+ Handle<Object> GetFileName() override;
+ Handle<Object> GetFunctionName() override;
+ Handle<Object> GetScriptNameOrSourceUrl() override;
+
+ int GetPosition() const override;
+ int GetLineNumber() override;
+ int GetColumnNumber() override;
+
+ MaybeHandle<String> ToString() override;
+};
+
class FrameArrayIterator {
public:
FrameArrayIterator(Isolate* isolate, Handle<FrameArray> array,
@@ -179,6 +199,7 @@ class FrameArrayIterator {
int next_frame_ix_;
WasmStackFrame wasm_frame_;
+ AsmJsWasmStackFrame asm_wasm_frame_;
JSStackFrame js_frame_;
};
« no previous file with comments | « src/isolate.cc ('k') | src/messages.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698