Add user name in the feedback data.

Add user name in the feedback data.

Added a map entry for user name in the feedback data. The key is
"Blimp Account", and the value will be Google account name of the current
user, such as someone@gmail.com.

When the user is not logged in, an empty string will be filled in as
the value in the feedback data map.

For early connect, the username can be catched in the feedback data.

BUG=653721
Committed: https://crrev.com/23665d9436ba067872f0b2c652dce17404393657
Cr-Commit-Position: refs/heads/master@{#430739}

[xingliu, 2016-10-10 21:15:40]

Description was changed from

==========
Add user name in the feedback data.

BUG=
==========

to

==========
Add user name in the feedback data.

Added a map entry for user name in the feedback data. The key is
"Blimp Account", and the value will be Google account id of the current
user.

When the user is not logged in, an empty string will be filled in as
the value in the feedback data map.

BUG=653721
==========

[xingliu, 2016-10-10 22:48:43]

Description was changed from

==========
Add user name in the feedback data.

Added a map entry for user name in the feedback data. The key is
"Blimp Account", and the value will be Google account id of the current
user.

When the user is not logged in, an empty string will be filled in as
the value in the feedback data map.

BUG=653721
==========

to

==========
Add user name in the feedback data.

Added a map entry for user name in the feedback data. The key is
"Blimp Account", and the value will be Google account name of the current
user, such as someone@gmail.com.

When the user is not logged in, an empty string will be filled in as
the value in the feedback data map.

BUG=653721
==========

[xingliu, 2016-10-10 22:52:32]

Description was changed from

==========
Add user name in the feedback data.

Added a map entry for user name in the feedback data. The key is
"Blimp Account", and the value will be Google account name of the current
user, such as someone@gmail.com.

When the user is not logged in, an empty string will be filled in as
the value in the feedback data map.

BUG=653721
==========

to

==========
Add user name in the feedback data.

Added a map entry for user name in the feedback data. The key is
"Blimp Account", and the value will be Google account name of the current
user, such as someone@gmail.com.

When the user is not logged in, an empty string will be filled in as
the value in the feedback data map.

For early connect, the username can be catched in the feedback data.

BUG=653721
==========

[xingliu, 2016-10-10 22:54:22]

xingliu@chromium.org changed reviewers:
+ dtrainor@chromium.org, nyquist@chromium.org

[xingliu, 2016-10-10 22:54:23]

Added user name in feedback data.

[nyquist, 2016-11-04 17:36:58]

Could you update the CL to pass information about the build type? The constants
live in Chrome, but maybe you could pass in whether the current build is stable,
beta or dev, and if it is, we would CHECK before adding the username (reminding
us to remove it). I'd probably just pass it as a bool throughout the code.

If it ends up being super weird with a CHECK, we could possibly just use an
if-statement, but bonus points for a crash.

You can read the data in the //chrome layer here:
https://cs.chromium.org/chromium/src/chrome/android/java/src/org/chromium/chr...

You can pass it through here:
https://cs.chromium.org/chromium/src/chrome/android/java/src/org/chromium/chr...

[xingliu, 2016-11-05 01:56:19]

The CQ bit was checked by xingliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-05 01:56:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-05 02:26:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-05 02:26:45]

Dry run: This issue passed the CQ dry run.

[xingliu, 2016-11-05 02:26:53]

Do a build version check for feedback data.

User name will be non-empty when user logged in and the current build is canary
or local.

If build is not canary or local and the code is trying to send any blimp
feedback data, print a warning.

[David Trainor- moved to gerrit, 2016-11-07 18:26:05]

https://codereview.chromium.org/2403913003/diff/80001/blimp/client/public/and...
File
blimp/client/public/android/java/src/org/chromium/blimp_public/BlimpClientContext.java
(right):

https://codereview.chromium.org/2403913003/diff/80001/blimp/client/public/and...
blimp/client/public/android/java/src/org/chromium/blimp_public/BlimpClientContext.java:61:
Map<String, String> getFeedbackMap(boolean isValidBuild);
@param isValidBuild.  Maybe name this something a little more clear or make sure
you have a nice description in the param doc.

[xingliu, 2016-11-07 18:41:58]

The CQ bit was checked by xingliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-07 18:42:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xingliu, 2016-11-07 19:07:13]

The CQ bit was checked by xingliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-07 19:07:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xingliu, 2016-11-07 19:08:36]

Added comments for isValidBuild.

https://codereview.chromium.org/2403913003/diff/80001/blimp/client/public/and...
File
blimp/client/public/android/java/src/org/chromium/blimp_public/BlimpClientContext.java
(right):

https://codereview.chromium.org/2403913003/diff/80001/blimp/client/public/and...
blimp/client/public/android/java/src/org/chromium/blimp_public/BlimpClientContext.java:61:
Map<String, String> getFeedbackMap(boolean isValidBuild);
On 2016/11/07 18:26:05, David Trainor wrote:
> @param isValidBuild.  Maybe name this something a little more clear or make
sure
> you have a nice description in the param doc.

Done. Leave the naming for now, and add comments in here and
blimp_client_context_impl.

[commit-bot: I haz the power, 2016-11-07 19:44:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-07 19:45:00]

Dry run: This issue passed the CQ dry run.

[nyquist, 2016-11-08 20:28:16]

https://codereview.chromium.org/2403913003/diff/120001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/feedback/FeedbackCollector.java
(right):

https://codereview.chromium.org/2403913003/diff/120001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/feedback/FeedbackCollector.java:293:
boolean isLocalOrCanaryBuild =
I think it makes sense to early out if this is false. That should make it be
less plumbing.

[xingliu, 2016-11-08 20:51:58]

The CQ bit was checked by xingliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-08 20:52:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xingliu, 2016-11-08 20:53:20]

The CQ bit was unchecked by xingliu@chromium.org

[xingliu, 2016-11-08 20:53:32]

The CQ bit was checked by xingliu@chromium.org to run a CQ dry run

[xingliu, 2016-11-08 20:54:16]

Thanks for the feedback, update the CL to only do version check in Java layer.

https://codereview.chromium.org/2403913003/diff/120001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/feedback/FeedbackCollector.java
(right):

https://codereview.chromium.org/2403913003/diff/120001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/feedback/FeedbackCollector.java:293:
boolean isLocalOrCanaryBuild =
On 2016/11/08 20:28:16, nyquist wrote:
> I think it makes sense to early out if this is false. That should make it be
> less plumbing.

Done, makes sense.

[commit-bot: I haz the power, 2016-11-08 20:54:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nyquist, 2016-11-08 20:58:59]

lgtm

https://codereview.chromium.org/2403913003/diff/140001/blimp/client/core/sess...
File blimp/client/core/session/identity_source.h (right):

https://codereview.chromium.org/2403913003/diff/140001/blimp/client/core/sess...
blimp/client/core/session/identity_source.h:39: // Returns the account name for
the current user.
Could you explain what happens if the user is not signed in?

[commit-bot: I haz the power, 2016-11-08 21:33:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-08 21:33:34]

Dry run: This issue passed the CQ dry run.

[xingliu, 2016-11-08 22:23:17]

The CQ bit was checked by xingliu@chromium.org

[commit-bot: I haz the power, 2016-11-08 22:23:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 22:35:57]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-11-08 22:50:27]

Description was changed from

==========
Add user name in the feedback data.

Added a map entry for user name in the feedback data. The key is
"Blimp Account", and the value will be Google account name of the current
user, such as someone@gmail.com.

When the user is not logged in, an empty string will be filled in as
the value in the feedback data map.

For early connect, the username can be catched in the feedback data.

BUG=653721
==========

to

==========
Add user name in the feedback data.

Added a map entry for user name in the feedback data. The key is
"Blimp Account", and the value will be Google account name of the current
user, such as someone@gmail.com.

When the user is not logged in, an empty string will be filled in as
the value in the feedback data map.

For early connect, the username can be catched in the feedback data.

BUG=653721

Committed: https://crrev.com/23665d9436ba067872f0b2c652dce17404393657
Cr-Commit-Position: refs/heads/master@{#430739}
==========

[commit-bot: I haz the power, 2016-11-08 22:50:28]

Patchset 8 (id:??) landed as
https://crrev.com/23665d9436ba067872f0b2c652dce17404393657
Cr-Commit-Position: refs/heads/master@{#430739}