Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2104)

Unified Diff: blimp/client/core/feedback/blimp_feedback_data.cc

Issue 2403913003: Add user name in the feedback data. (Closed)
Patch Set: Version check only in Java layer. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/client/core/feedback/blimp_feedback_data.cc
diff --git a/blimp/client/core/feedback/blimp_feedback_data.cc b/blimp/client/core/feedback/blimp_feedback_data.cc
index e2d3ff9615debabe01d304af021f9920a21a6c2d..5df8f800b31400b85504db4bba6034266a604762 100644
--- a/blimp/client/core/feedback/blimp_feedback_data.cc
+++ b/blimp/client/core/feedback/blimp_feedback_data.cc
@@ -10,6 +10,7 @@ namespace blimp {
namespace client {
const char kFeedbackSupportedKey[] = "Blimp Supported";
const char kFeedbackHasVisibleBlimpContents[] = "Blimp Visible";
+const char kFeedbackUserNameKey[] = "Blimp Account";
namespace {
std::string HasVisibleBlimpContents(
@@ -26,11 +27,13 @@ std::string HasVisibleBlimpContents(
} // namespace
std::unordered_map<std::string, std::string> CreateBlimpFeedbackData(
- BlimpContentsManager* blimp_contents_manager) {
+ BlimpContentsManager* blimp_contents_manager,
+ const std::string& username) {
std::unordered_map<std::string, std::string> data;
data.insert(std::make_pair(kFeedbackSupportedKey, "true"));
data.insert(std::make_pair(kFeedbackHasVisibleBlimpContents,
HasVisibleBlimpContents(blimp_contents_manager)));
+ data.insert(std::make_pair(kFeedbackUserNameKey, username));
return data;
}

Powered by Google App Engine
This is Rietveld 408576698