Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Unified Diff: blimp/client/core/feedback/blimp_feedback_data_unittest.cc

Issue 2403913003: Add user name in the feedback data. (Closed)
Patch Set: Version check only in Java layer. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/client/core/feedback/blimp_feedback_data_unittest.cc
diff --git a/blimp/client/core/feedback/blimp_feedback_data_unittest.cc b/blimp/client/core/feedback/blimp_feedback_data_unittest.cc
index 1542a93410b2ecc6e1002619f7f506702bcfcd44..a152135f7f4aed86de49575d25aae2fb5ee8415a 100644
--- a/blimp/client/core/feedback/blimp_feedback_data_unittest.cc
+++ b/blimp/client/core/feedback/blimp_feedback_data_unittest.cc
@@ -22,6 +22,8 @@
#include "ui/android/window_android.h"
#endif // defined(OS_ANDROID)
+const char kDefaultUserName[] = "mock_user";
+
namespace blimp {
namespace client {
namespace {
@@ -70,7 +72,7 @@ class BlimpFeedbackDataTest : public testing::Test {
TEST_F(BlimpFeedbackDataTest, IncludesBlimpIsSupported) {
std::unordered_map<std::string, std::string> data =
- CreateBlimpFeedbackData(&blimp_contents_manager_);
+ CreateBlimpFeedbackData(&blimp_contents_manager_, kDefaultUserName);
auto search = data.find(kFeedbackSupportedKey);
ASSERT_TRUE(search != data.end());
EXPECT_EQ("true", search->second);
@@ -84,19 +86,37 @@ TEST_F(BlimpFeedbackDataTest, CheckVisibilityCalculation) {
// Verify that visibility is false when there are no visible BlimpContents.
blimp_contents->Hide();
std::unordered_map<std::string, std::string> data =
- CreateBlimpFeedbackData(&blimp_contents_manager_);
+ CreateBlimpFeedbackData(&blimp_contents_manager_, kDefaultUserName);
auto search = data.find(kFeedbackHasVisibleBlimpContents);
ASSERT_TRUE(search != data.end());
EXPECT_EQ("false", search->second);
// Verify that visibility is true when there are visible BlimpContents.
blimp_contents->Show();
- data = CreateBlimpFeedbackData(&blimp_contents_manager_);
+ data = CreateBlimpFeedbackData(&blimp_contents_manager_, kDefaultUserName);
search = data.find(kFeedbackHasVisibleBlimpContents);
ASSERT_TRUE(search != data.end());
EXPECT_EQ("true", search->second);
}
+TEST_F(BlimpFeedbackDataTest, CheckUserName) {
+ // Verify non-empty user name in the feedback data.
+ std::unordered_map<std::string, std::string> data =
+ CreateBlimpFeedbackData(&blimp_contents_manager_, kDefaultUserName);
+ auto search = data.find(kFeedbackUserNameKey);
+ ASSERT_TRUE(search != data.end());
+ EXPECT_EQ(kDefaultUserName, search->second);
+}
+
+TEST_F(BlimpFeedbackDataTest, CheckEmptyUserName) {
+ // Verify empty user name in the feedback data.
+ std::unordered_map<std::string, std::string> data =
+ CreateBlimpFeedbackData(&blimp_contents_manager_, "");
+ auto search = data.find(kFeedbackUserNameKey);
+ ASSERT_TRUE(search != data.end());
+ EXPECT_EQ("", search->second);
+}
+
} // namespace
} // namespace client
} // namespace blimp

Powered by Google App Engine
This is Rietveld 408576698