chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.mm - Issue 2403763003: [Mac] Address buggy permission bubble behaviour on dismissal via ESC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.mm

Issue 2403763003: [Mac] Address buggy permission bubble behaviour on dismissal via ESC. (Closed)

Patch Set: Use Closing Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/browser_window_controller.mm ('k') | chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.mm

diff --git a/chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.mm b/chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.mm

index 61bd246166717a1e644ef40c9ad7ad491b978620..fb8f01ffd90a99a27b3bae86fd3cb3ea83a9a3db 100644

--- a/chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.mm

+++ b/chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.mm

@@ -12,9 +12,7 @@

#import "ui/base/cocoa/nsview_additions.h"

PermissionBubbleCocoa::PermissionBubbleCocoa(Browser* browser)

- : browser_(browser), delegate_(nullptr), bubbleController_(nil) {

- DCHECK(browser);

+ : browser_(browser), delegate_(nullptr), bubbleController_(nil) {}

PermissionBubbleCocoa::~PermissionBubbleCocoa() {

}

@@ -22,6 +20,8 @@ PermissionBubbleCocoa::~PermissionBubbleCocoa() {

void PermissionBubbleCocoa::Show(

const std::vector<PermissionRequest*>& requests,

const std::vector<bool>& accept_state) {

+ DCHECK(browser_);

if (!bubbleController_) {

bubbleController_ =

[[PermissionBubbleController alloc] initWithBrowser:browser_