chrome/browser/ui/cocoa/browser_window_controller.mm - Issue 2403763003: [Mac] Address buggy permission bubble behaviour on dismissal via ESC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/browser_window_controller.mm

Issue 2403763003: [Mac] Address buggy permission bubble behaviour on dismissal via ESC. (Closed)

Patch Set: Use Closing Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/browser_window_controller.mm

diff --git a/chrome/browser/ui/cocoa/browser_window_controller.mm b/chrome/browser/ui/cocoa/browser_window_controller.mm

index 546fa63014235a7662543906b402b3046cb6b926..6ae2ae57fac3618b3ce5a41447cc8a61abc59cef 100644

--- a/chrome/browser/ui/cocoa/browser_window_controller.mm

+++ b/chrome/browser/ui/cocoa/browser_window_controller.mm

@@ -1591,9 +1591,9 @@ bool IsTabDetachingInFullscreenEnabled() {

}

- (void)dismissPermissionBubble {

- PermissionRequestManager* manager = [self permissionRequestManager];

- if (manager)

- manager->HideBubble();

+ PermissionPrompt::Delegate* delegate = [self permissionRequestManager];

+ if (delegate)

+ delegate->Closing();

}

// Nil out the weak translate bubble controller reference.