chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm - Issue 2403763003: [Mac] Address buggy permission bubble behaviour on dismissal via ESC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm

Issue 2403763003: [Mac] Address buggy permission bubble behaviour on dismissal via ESC. (Closed)

Patch Set: Use Closing Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.mm ('k') | chrome/browser/ui/views/website_settings/permission_prompt_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm

diff --git a/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm b/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm

index 6cb51087c6395680e5ad92076eeefd685ffeb511..0d3e4e8a7ab67718747d299bb6c9835c0b64a6f1 100644

--- a/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm

+++ b/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm

@@ -228,6 +228,9 @@ const NSInteger kFullscreenLeftOffset = 40;

// vertical center of |viewB|.

+ (void)alignCenterOf:(NSView*)viewA verticallyToCenterOf:(NSView*)viewB;

+// BaseBubbleController override.

+- (IBAction)cancel:(id)sender;

@end

@implementation PermissionBubbleController

@@ -664,4 +667,11 @@ const NSInteger kFullscreenLeftOffset = 40;

[viewA setFrameOrigin:frameA.origin];

}

+- (IBAction)cancel:(id)sender {

+ // This is triggered by ESC when the bubble has focus.

+ DCHECK(delegate_);

+ delegate_->Closing();

+ [super cancel:sender];

@end // implementation PermissionBubbleController