Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4508)

Unified Diff: chrome/browser/permissions/permission_request_manager.h

Issue 2403763003: [Mac] Address buggy permission bubble behaviour on dismissal via ESC. (Closed)
Patch Set: Use Closing Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/browser_window_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/permissions/permission_request_manager.h
diff --git a/chrome/browser/permissions/permission_request_manager.h b/chrome/browser/permissions/permission_request_manager.h
index b618b0cf8d8b6fd41191a4114db7f702625988f1..0348ab1e21903f245f613c3ff0565f8ce7cd2fa6 100644
--- a/chrome/browser/permissions/permission_request_manager.h
+++ b/chrome/browser/permissions/permission_request_manager.h
@@ -70,7 +70,9 @@ class PermissionRequestManager
// at which time the caller is free to delete the request.
void CancelRequest(PermissionRequest* request);
- // Hides the bubble.
+ // Temporarily hides the bubble, and destroys the prompt UI surface. Any
+ // existing requests will be reshown when DisplayPendingRequests is called
+ // (e.g. when switching tabs away and back to a page with a prompt).
void HideBubble();
// Will show a permission bubble if there is a pending permission request on
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/browser_window_controller.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698