Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 24031003: remove most uses of Isolate::Current in arch specific files (Closed)

Created:
7 years, 3 months ago by dcarney
Modified:
7 years, 3 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

remove most uses of Isolate::Current in arch specific files R=svenpanne@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=16643

Patch Set 1 #

Total comments: 1

Patch Set 2 : more #

Patch Set 3 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -77 lines) Patch
M src/arm/assembler-arm.cc View 1 chunk +1 line, -4 lines 0 comments Download
M src/arm/assembler-arm-inl.h View 1 2 chunks +2 lines, -3 lines 0 comments Download
M src/arm/code-stubs-arm.h View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M src/arm/debug-arm.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M src/arm/ic-arm.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M src/arm/regexp-macro-assembler-arm.cc View 2 chunks +1 line, -2 lines 0 comments Download
M src/assembler.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/code-stubs.h View 7 chunks +8 lines, -7 lines 0 comments Download
M src/code-stubs.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/assembler-ia32-inl.h View 1 3 chunks +3 lines, -7 lines 0 comments Download
M src/ia32/code-stubs-ia32.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/ia32/debug-ia32.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/ia32/ic-ia32.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/ia32/regexp-macro-assembler-ia32.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/mark-compact.cc View 1 4 chunks +10 lines, -7 lines 0 comments Download
M src/objects-visiting-inl.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/x64/assembler-x64-inl.h View 1 2 chunks +2 lines, -3 lines 0 comments Download
M src/x64/code-stubs-x64.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M src/x64/debug-x64.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/x64/ic-x64.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M src/x64/regexp-macro-assembler-x64.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
dcarney
7 years, 3 months ago (2013-09-11 10:31:14 UTC) #1
Sven Panne
LGTM with a nit. https://codereview.chromium.org/24031003/diff/1/src/arm/code-stubs-arm.h File src/arm/code-stubs-arm.h (right): https://codereview.chromium.org/24031003/diff/1/src/arm/code-stubs-arm.h#newcode235 src/arm/code-stubs-arm.h:235: bool IsPregenerated(Isolate* isolate) V8_OVERRIDE; Hmmm, ...
7 years, 3 months ago (2013-09-11 10:45:29 UTC) #2
dcarney
7 years, 3 months ago (2013-09-11 10:51:37 UTC) #3
Message was sent while issue was closed. 
Committed patchset #3 manually as r16643 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698