Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Side by Side Diff: src/arm/debug-arm.cc

Issue 24031003: remove most uses of Isolate::Current in arch specific files (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: nit Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/code-stubs-arm.cc ('k') | src/arm/ic-arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
48 // add sp, sp, #4 48 // add sp, sp, #4
49 // bx lr 49 // bx lr
50 // to a call to the debug break return code. 50 // to a call to the debug break return code.
51 // ldr ip, [pc, #0] 51 // ldr ip, [pc, #0]
52 // blx ip 52 // blx ip
53 // <debug break return code entry point address> 53 // <debug break return code entry point address>
54 // bktp 0 54 // bktp 0
55 CodePatcher patcher(rinfo()->pc(), Assembler::kJSReturnSequenceInstructions); 55 CodePatcher patcher(rinfo()->pc(), Assembler::kJSReturnSequenceInstructions);
56 patcher.masm()->ldr(v8::internal::ip, MemOperand(v8::internal::pc, 0)); 56 patcher.masm()->ldr(v8::internal::ip, MemOperand(v8::internal::pc, 0));
57 patcher.masm()->blx(v8::internal::ip); 57 patcher.masm()->blx(v8::internal::ip);
58 patcher.Emit(Isolate::Current()->debug()->debug_break_return()->entry()); 58 patcher.Emit(
59 debug_info_->GetIsolate()->debug()->debug_break_return()->entry());
59 patcher.masm()->bkpt(0); 60 patcher.masm()->bkpt(0);
60 } 61 }
61 62
62 63
63 // Restore the JS frame exit code. 64 // Restore the JS frame exit code.
64 void BreakLocationIterator::ClearDebugBreakAtReturn() { 65 void BreakLocationIterator::ClearDebugBreakAtReturn() {
65 rinfo()->PatchCode(original_rinfo()->pc(), 66 rinfo()->PatchCode(original_rinfo()->pc(),
66 Assembler::kJSReturnSequenceInstructions); 67 Assembler::kJSReturnSequenceInstructions);
67 } 68 }
68 69
(...skipping 19 matching lines...) Expand all
88 // mov r2, r2 89 // mov r2, r2
89 // mov r2, r2 90 // mov r2, r2
90 // mov r2, r2 91 // mov r2, r2
91 // to a call to the debug break slot code. 92 // to a call to the debug break slot code.
92 // ldr ip, [pc, #0] 93 // ldr ip, [pc, #0]
93 // blx ip 94 // blx ip
94 // <debug break slot code entry point address> 95 // <debug break slot code entry point address>
95 CodePatcher patcher(rinfo()->pc(), Assembler::kDebugBreakSlotInstructions); 96 CodePatcher patcher(rinfo()->pc(), Assembler::kDebugBreakSlotInstructions);
96 patcher.masm()->ldr(v8::internal::ip, MemOperand(v8::internal::pc, 0)); 97 patcher.masm()->ldr(v8::internal::ip, MemOperand(v8::internal::pc, 0));
97 patcher.masm()->blx(v8::internal::ip); 98 patcher.masm()->blx(v8::internal::ip);
98 patcher.Emit(Isolate::Current()->debug()->debug_break_slot()->entry()); 99 patcher.Emit(
100 debug_info_->GetIsolate()->debug()->debug_break_slot()->entry());
99 } 101 }
100 102
101 103
102 void BreakLocationIterator::ClearDebugBreakAtSlot() { 104 void BreakLocationIterator::ClearDebugBreakAtSlot() {
103 ASSERT(IsDebugBreakSlot()); 105 ASSERT(IsDebugBreakSlot());
104 rinfo()->PatchCode(original_rinfo()->pc(), 106 rinfo()->PatchCode(original_rinfo()->pc(),
105 Assembler::kDebugBreakSlotInstructions); 107 Assembler::kDebugBreakSlotInstructions);
106 } 108 }
107 109
108 const bool Debug::FramePaddingLayout::kIsSupported = false; 110 const bool Debug::FramePaddingLayout::kIsSupported = false;
(...skipping 216 matching lines...) Expand 10 before | Expand all | Expand 10 after
325 327
326 #undef __ 328 #undef __
327 329
328 330
329 331
330 #endif // ENABLE_DEBUGGER_SUPPORT 332 #endif // ENABLE_DEBUGGER_SUPPORT
331 333
332 } } // namespace v8::internal 334 } } // namespace v8::internal
333 335
334 #endif // V8_TARGET_ARCH_ARM 336 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « src/arm/code-stubs-arm.cc ('k') | src/arm/ic-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698