Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Side by Side Diff: src/ia32/debug-ia32.cc

Issue 24031003: remove most uses of Isolate::Current in arch specific files (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: nit Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/code-stubs-ia32.cc ('k') | src/ia32/ic-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
42 return Debug::IsDebugBreakAtReturn(rinfo()); 42 return Debug::IsDebugBreakAtReturn(rinfo());
43 } 43 }
44 44
45 45
46 // Patch the JS frame exit code with a debug break call. See 46 // Patch the JS frame exit code with a debug break call. See
47 // CodeGenerator::VisitReturnStatement and VirtualFrame::Exit in codegen-ia32.cc 47 // CodeGenerator::VisitReturnStatement and VirtualFrame::Exit in codegen-ia32.cc
48 // for the precise return instructions sequence. 48 // for the precise return instructions sequence.
49 void BreakLocationIterator::SetDebugBreakAtReturn() { 49 void BreakLocationIterator::SetDebugBreakAtReturn() {
50 ASSERT(Assembler::kJSReturnSequenceLength >= 50 ASSERT(Assembler::kJSReturnSequenceLength >=
51 Assembler::kCallInstructionLength); 51 Assembler::kCallInstructionLength);
52 Isolate* isolate = Isolate::Current(); 52 rinfo()->PatchCodeWithCall(
53 rinfo()->PatchCodeWithCall(isolate->debug()->debug_break_return()->entry(), 53 debug_info_->GetIsolate()->debug()->debug_break_return()->entry(),
54 Assembler::kJSReturnSequenceLength - Assembler::kCallInstructionLength); 54 Assembler::kJSReturnSequenceLength - Assembler::kCallInstructionLength);
55 } 55 }
56 56
57 57
58 // Restore the JS frame exit code. 58 // Restore the JS frame exit code.
59 void BreakLocationIterator::ClearDebugBreakAtReturn() { 59 void BreakLocationIterator::ClearDebugBreakAtReturn() {
60 rinfo()->PatchCode(original_rinfo()->pc(), 60 rinfo()->PatchCode(original_rinfo()->pc(),
61 Assembler::kJSReturnSequenceLength); 61 Assembler::kJSReturnSequenceLength);
62 } 62 }
63 63
64 64
65 // A debug break in the frame exit code is identified by the JS frame exit code 65 // A debug break in the frame exit code is identified by the JS frame exit code
66 // having been patched with a call instruction. 66 // having been patched with a call instruction.
67 bool Debug::IsDebugBreakAtReturn(RelocInfo* rinfo) { 67 bool Debug::IsDebugBreakAtReturn(RelocInfo* rinfo) {
68 ASSERT(RelocInfo::IsJSReturn(rinfo->rmode())); 68 ASSERT(RelocInfo::IsJSReturn(rinfo->rmode()));
69 return rinfo->IsPatchedReturnSequence(); 69 return rinfo->IsPatchedReturnSequence();
70 } 70 }
71 71
72 72
73 bool BreakLocationIterator::IsDebugBreakAtSlot() { 73 bool BreakLocationIterator::IsDebugBreakAtSlot() {
74 ASSERT(IsDebugBreakSlot()); 74 ASSERT(IsDebugBreakSlot());
75 // Check whether the debug break slot instructions have been patched. 75 // Check whether the debug break slot instructions have been patched.
76 return rinfo()->IsPatchedDebugBreakSlotSequence(); 76 return rinfo()->IsPatchedDebugBreakSlotSequence();
77 } 77 }
78 78
79 79
80 void BreakLocationIterator::SetDebugBreakAtSlot() { 80 void BreakLocationIterator::SetDebugBreakAtSlot() {
81 ASSERT(IsDebugBreakSlot()); 81 ASSERT(IsDebugBreakSlot());
82 Isolate* isolate = Isolate::Current(); 82 Isolate* isolate = debug_info_->GetIsolate();
83 rinfo()->PatchCodeWithCall( 83 rinfo()->PatchCodeWithCall(
84 isolate->debug()->debug_break_slot()->entry(), 84 isolate->debug()->debug_break_slot()->entry(),
85 Assembler::kDebugBreakSlotLength - Assembler::kCallInstructionLength); 85 Assembler::kDebugBreakSlotLength - Assembler::kCallInstructionLength);
86 } 86 }
87 87
88 88
89 void BreakLocationIterator::ClearDebugBreakAtSlot() { 89 void BreakLocationIterator::ClearDebugBreakAtSlot() {
90 ASSERT(IsDebugBreakSlot()); 90 ASSERT(IsDebugBreakSlot());
91 rinfo()->PatchCode(original_rinfo()->pc(), Assembler::kDebugBreakSlotLength); 91 rinfo()->PatchCode(original_rinfo()->pc(), Assembler::kDebugBreakSlotLength);
92 } 92 }
(...skipping 270 matching lines...) Expand 10 before | Expand all | Expand 10 after
363 363
364 const bool Debug::kFrameDropperSupported = true; 364 const bool Debug::kFrameDropperSupported = true;
365 365
366 #undef __ 366 #undef __
367 367
368 #endif // ENABLE_DEBUGGER_SUPPORT 368 #endif // ENABLE_DEBUGGER_SUPPORT
369 369
370 } } // namespace v8::internal 370 } } // namespace v8::internal
371 371
372 #endif // V8_TARGET_ARCH_IA32 372 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/ia32/code-stubs-ia32.cc ('k') | src/ia32/ic-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698