Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 2402363002: [Math] implement Math.random as TFJ builtin. (Closed)

Created:
4 years, 2 months ago by Yang
Modified:
4 years, 2 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, rmcilroy, Yang
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Math] implement Math.random as TFJ builtin. R=bmeurer@chromium.org BUG=v8:5049, v8:5086 Committed: https://crrev.com/0d8e52123eefaf3858005f96f0db3af037222853 Cr-Commit-Position: refs/heads/master@{#40149}

Patch Set 1 #

Patch Set 2 : fix #

Patch Set 3 : rebase #

Patch Set 4 : fix golden file #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -115 lines) Patch
M BUILD.gn View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M src/bootstrapper.cc View 1 2 2 chunks +5 lines, -0 lines 0 comments Download
M src/builtins/builtins.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M src/builtins/builtins-math.cc View 1 1 chunk +40 lines, -0 lines 0 comments Download
M src/code-stub-assembler.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/code-stub-assembler.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/contexts.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M src/factory.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/js/collection.js View 1 chunk +1 line, -2 lines 0 comments Download
D src/js/math.js View 1 chunk +0 lines, -60 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-maths.cc View 1 chunk +33 lines, -42 lines 0 comments Download
M src/snapshot/partial-serializer.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/v8.gyp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/CallRuntime.golden View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/debug-script.js View 1 chunk +3 lines, -3 lines 2 comments Download
M test/mjsunit/mirror-script.js View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 27 (20 generated)
Yang
4 years, 2 months ago (2016-10-10 13:38:01 UTC) #1
Yang
This finally removes src/js/math.js. Let's get this landed first before worrying about improving the implementation ...
4 years, 2 months ago (2016-10-10 13:38:42 UTC) #2
Benedikt Meurer
LGTM! https://codereview.chromium.org/2402363002/diff/60001/test/mjsunit/debug-script.js File test/mjsunit/debug-script.js (right): https://codereview.chromium.org/2402363002/diff/60001/test/mjsunit/debug-script.js#newcode83 test/mjsunit/debug-script.js:83: var array_script = Debug.findScript('native array.js'); Hah! Moving furniture ...
4 years, 2 months ago (2016-10-11 06:43:45 UTC) #20
Yang
https://codereview.chromium.org/2402363002/diff/60001/test/mjsunit/debug-script.js File test/mjsunit/debug-script.js (right): https://codereview.chromium.org/2402363002/diff/60001/test/mjsunit/debug-script.js#newcode83 test/mjsunit/debug-script.js:83: var array_script = Debug.findScript('native array.js'); On 2016/10/11 06:43:45, Benedikt ...
4 years, 2 months ago (2016-10-11 06:44:26 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2402363002/60001
4 years, 2 months ago (2016-10-11 06:44:39 UTC) #23
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 2 months ago (2016-10-11 06:47:05 UTC) #25
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 06:47:25 UTC) #27
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/0d8e52123eefaf3858005f96f0db3af037222853
Cr-Commit-Position: refs/heads/master@{#40149}

Powered by Google App Engine
This is Rietveld 408576698