Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 24018007: Add a GrCustomCoordsTextureEffect class (Closed)

Created:
7 years, 3 months ago by Chris Dalton
Modified:
7 years, 2 months ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Add a GrCustomCoordsTextureEffect class Extracts a GrCustomCoordsTextureEffect class from GrSimpleTextureEffect. This way there are no effects that can conditionally require a vertex shader. They either always need one or never do. Also removes kCustom_CoordsType from the CoordsType enum in GrEffect (that enum is really only meant for coords provided by the framework), and updates GrSimpleTextureEffect::TestCreate to make the effect with position as well, instead of just local coords. Committed: http://code.google.com/p/skia/source/detail?r=11531

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+179 lines, -74 lines) Patch
M gyp/gpu.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M include/gpu/GrEffect.h View 1 chunk +1 line, -5 lines 0 comments Download
M src/gpu/GrTextContext.cpp View 2 chunks +2 lines, -1 line 0 comments Download
A src/gpu/effects/GrCustomCoordsTextureEffect.h View 1 chunk +49 lines, -0 lines 0 comments Download
A src/gpu/effects/GrCustomCoordsTextureEffect.cpp View 1 1 chunk +111 lines, -0 lines 0 comments Download
M src/gpu/effects/GrSimpleTextureEffect.h View 5 chunks +0 lines, -18 lines 0 comments Download
M src/gpu/effects/GrSimpleTextureEffect.cpp View 4 chunks +13 lines, -45 lines 0 comments Download
M src/gpu/effects/GrSingleTextureEffect.h View 1 chunk +1 line, -3 lines 0 comments Download
M src/gpu/gl/GrGLEffectMatrix.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Chris Dalton
7 years, 3 months ago (2013-09-23 01:53:08 UTC) #1
bsalomon
lgtm w/ some minor nit comments. https://codereview.chromium.org/24018007/diff/1/src/gpu/effects/GrCustomCoordsTextureEffect.cpp File src/gpu/effects/GrCustomCoordsTextureEffect.cpp (right): https://codereview.chromium.org/24018007/diff/1/src/gpu/effects/GrCustomCoordsTextureEffect.cpp#newcode2 src/gpu/effects/GrCustomCoordsTextureEffect.cpp:2: * Copyright 2012 ...
7 years, 3 months ago (2013-09-23 14:13:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/cdalton@nvidia.com/24018007/6001
7 years, 2 months ago (2013-09-30 18:15:55 UTC) #3
commit-bot: I haz the power
7 years, 2 months ago (2013-09-30 18:41:45 UTC) #4
Message was sent while issue was closed.
Change committed as 11531

Powered by Google App Engine
This is Rietveld 408576698