Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 24012002: Move Range code to gfx. (Closed)

Created:
7 years, 3 months ago by Ben Goodger (Google)
Modified:
7 years, 3 months ago
CC:
chromium-reviews, sadrul, nkostylev+watch_chromium.org, sievers+watch_chromium.org, rsesek+watch_chromium.org, piman+watch_chromium.org, Ilya Sherman, yusukes+watch_chromium.org, tim+watch_chromium.org, extensions-reviews_chromium.org, ben+watch_chromium.org, benquan, stevenjb+watch_chromium.org, jam, joi+watch-content_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, miu+watch_chromium.org, derat+watch_chromium.org, haitaol+watch_chromium.org, penghuang+watch_chromium.org, jbauman+watch_chromium.org, oshima+watch_chromium.org, Albert Bodenhamer, cc-bugs_chromium.org, rouslan+autofillwatch_chromium.org, chrome-apps-syd-reviews_chromium.org, James Su, tfarina, Dane Wallinga, dyu1, estade+watch_chromium.org, danakj+watch_chromium.org, rsimha+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Move Range code to gfx. Part of a set of changes to fix the circular dependency between ui/base and ui/gfx, with the aim of making gfx its own component. R=jam@chromium.org, jschuh@chromium.org, rsesek@chromium.org BUG=285385, 103304 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221762

Patch Set 1 #

Patch Set 2 : Merge. #

Patch Set 3 : Build fixes #

Patch Set 4 : More IME fixes #

Patch Set 5 : , #

Patch Set 6 : . #

Patch Set 7 : d #

Unified diffs Side-by-side diffs Delta from patch set Stats (+923 lines, -1518 lines) Patch
M ash/system/user/tray_user.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/input_method/textinput_surroundingtext_browsertest.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/input_method/textinput_test_helper.h View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/input_method/textinput_test_helper.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/ui/echo_dialog_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/ui/echo_dialog_view.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/app_list/search/tokenized_string.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/app_list/search/tokenized_string.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/search/tokenized_string_match.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/app_list/search/tokenized_string_match.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/app_list/search/tokenized_string_match_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_controller_impl.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_types.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_types.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_view_delegate.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/autofill/generated_credit_card_bubble_controller.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/autofill/generated_credit_card_bubble_controller.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/autofill/generated_credit_card_bubble_controller_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/autofill/mock_autofill_dialog_view_delegate.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/bookmarks/bookmark_bubble_sign_in_delegate_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
chrome/browser/ui/cocoa/autofill/autofill_main_container.mm View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/autofill/autofill_dialog_views.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/autofill/autofill_dialog_views.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/autofill/generated_credit_card_bubble_views.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/autofill/generated_credit_card_bubble_views.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_sync_promo_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_sync_promo_view.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_sync_promo_view_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_view_views.h View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_view_views.cc View 10 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_view_win.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_view_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M content/browser/renderer_host/gtk_im_context_wrapper.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M content/browser/renderer_host/ime_adapter_android.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.h View 1 2 chunks +5 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.h View 3 chunks +6 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.h View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.h View 1 2 3 4 3 chunks +8 lines, -8 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 2 3 4 6 chunks +12 lines, -12 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_base.h View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_base.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_gtk.h View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_gtk.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_guest.h View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_guest.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.h View 1 4 chunks +9 lines, -9 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 1 13 chunks +23 lines, -23 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac_unittest.mm View 8 chunks +72 lines, -72 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_win.h View 1 3 chunks +8 lines, -8 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_win.cc View 1 11 chunks +12 lines, -12 lines 0 comments Download
M content/browser/renderer_host/test_render_view_host.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/text_input_client_mac.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/text_input_client_message_filter.h View 1 chunk +1 line, -4 lines 0 comments Download
M content/browser/renderer_host/text_input_client_message_filter.mm View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/touch_editable_impl_aura.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/child/site_isolation_policy_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/content_param_traits.h View 2 chunks +6 lines, -6 lines 0 comments Download
M content/common/content_param_traits.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M content/common/mac/attributed_string_coder.h View 3 chunks +5 lines, -5 lines 0 comments Download
M content/common/mac/attributed_string_coder.mm View 5 chunks +5 lines, -5 lines 0 comments Download
M content/common/mac/attributed_string_coder_unittest.mm View 1 chunk +3 lines, -3 lines 0 comments Download
M content/common/text_input_client_messages.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/common/view_messages.h View 4 chunks +4 lines, -4 lines 0 comments Download
M content/port/browser/render_widget_host_view_port.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/pepper/pepper_plugin_instance_impl.h View 2 chunks +5 lines, -5 lines 0 comments Download
M content/renderer/pepper/pepper_plugin_instance_impl.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/render_view_browsertest.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M content/renderer/render_view_impl.h View 1 5 chunks +5 lines, -5 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 8 chunks +11 lines, -10 lines 0 comments Download
M content/renderer/render_view_impl_unittest.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M content/renderer/render_widget.h View 5 chunks +6 lines, -6 lines 0 comments Download
M content/renderer/render_widget.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M content/renderer/text_input_client_observer.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/text_input_client_observer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/app_list/search_result.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/gtk/gtk_im_context_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/ime/composition_text.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/ime/composition_text.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/ime/input_method_ibus.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/base/ime/input_method_ibus.cc View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M ui/base/ime/input_method_ibus_unittest.cc View 1 2 6 chunks +16 lines, -16 lines 0 comments Download
M ui/base/ime/input_method_win.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M ui/base/ime/text_input_client.h View 3 chunks +7 lines, -7 lines 0 comments Download
M ui/base/ime/win/imm32_manager.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/ime/win/tsf_event_router.h View 3 chunks +4 lines, -4 lines 0 comments Download
M ui/base/ime/win/tsf_event_router.cc View 7 chunks +16 lines, -16 lines 0 comments Download
M ui/base/ime/win/tsf_text_store.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/ime/win/tsf_text_store_unittest.cc View 1 2 3 2 chunks +7 lines, -7 lines 0 comments Download
D ui/base/range/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
D ui/base/range/range.h View 1 chunk +0 lines, -117 lines 0 comments Download
D ui/base/range/range.cc View 1 chunk +0 lines, -87 lines 0 comments Download
D ui/base/range/range_mac.mm View 1 chunk +0 lines, -36 lines 0 comments Download
D ui/base/range/range_mac_unittest.mm View 1 chunk +0 lines, -43 lines 0 comments Download
D ui/base/range/range_unittest.cc View 1 chunk +0 lines, -208 lines 0 comments Download
D ui/base/range/range_win.cc View 1 chunk +0 lines, -45 lines 0 comments Download
D ui/base/range/range_win_unittest.cc View 1 chunk +0 lines, -63 lines 0 comments Download
M ui/gfx/break_list.h View 5 chunks +7 lines, -7 lines 0 comments Download
M ui/gfx/break_list_unittest.cc View 6 chunks +41 lines, -41 lines 0 comments Download
M ui/gfx/canvas_skia.cc View 6 chunks +9 lines, -9 lines 0 comments Download
A + ui/gfx/range/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/range/range.h View 3 chunks +6 lines, -6 lines 0 comments Download
A + ui/gfx/range/range.cc View 3 chunks +3 lines, -3 lines 0 comments Download
A + ui/gfx/range/range_mac.mm View 1 chunk +2 lines, -2 lines 0 comments Download
A + ui/gfx/range/range_mac_unittest.mm View 3 chunks +6 lines, -6 lines 0 comments Download
A + ui/gfx/range/range_unittest.cc View 12 chunks +35 lines, -35 lines 0 comments Download
A + ui/gfx/range/range_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + ui/gfx/range/range_win_unittest.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M ui/gfx/render_text.h View 10 chunks +13 lines, -13 lines 0 comments Download
M ui/gfx/render_text.cc View 12 chunks +19 lines, -18 lines 0 comments Download
M ui/gfx/render_text_linux.h View 1 chunk +3 lines, -2 lines 0 comments Download
M ui/gfx/render_text_linux.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M ui/gfx/render_text_mac.h View 1 chunk +3 lines, -2 lines 0 comments Download
M ui/gfx/render_text_mac.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M ui/gfx/render_text_unittest.cc View 12 chunks +38 lines, -38 lines 0 comments Download
M ui/gfx/render_text_win.h View 1 2 chunks +4 lines, -3 lines 0 comments Download
M ui/gfx/render_text_win.cc View 1 5 chunks +18 lines, -18 lines 0 comments Download
M ui/gfx/selection_model.h View 1 3 chunks +4 lines, -4 lines 0 comments Download
M ui/gfx/selection_model.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/keyboard/keyboard_controller_unittest.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M ui/ui.gyp View 1 3 chunks +5 lines, -5 lines 0 comments Download
M ui/ui_unittests.gypi View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/views/controls/prefix_selector.h View 1 chunk +6 lines, -6 lines 0 comments Download
M ui/views/controls/prefix_selector.cc View 2 chunks +10 lines, -10 lines 0 comments Download
M ui/views/controls/styled_label.h View 5 chunks +5 lines, -5 lines 0 comments Download
M ui/views/controls/styled_label.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/views/controls/styled_label_listener.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/controls/styled_label_unittest.cc View 8 chunks +13 lines, -13 lines 0 comments Download
M ui/views/controls/textfield/native_textfield_views.h View 4 chunks +11 lines, -11 lines 0 comments Download
M ui/views/controls/textfield/native_textfield_views.cc View 16 chunks +21 lines, -21 lines 0 comments Download
M ui/views/controls/textfield/native_textfield_views_unittest.cc View 12 chunks +16 lines, -16 lines 0 comments Download
M ui/views/controls/textfield/native_textfield_win.h View 3 chunks +5 lines, -5 lines 0 comments Download
M ui/views/controls/textfield/native_textfield_win.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M ui/views/controls/textfield/native_textfield_wrapper.h View 3 chunks +5 lines, -5 lines 0 comments Download
M ui/views/controls/textfield/textfield.h View 1 3 chunks +5 lines, -5 lines 0 comments Download
M ui/views/controls/textfield/textfield.cc View 1 5 chunks +6 lines, -6 lines 0 comments Download
M ui/views/controls/textfield/textfield_views_model.h View 5 chunks +6 lines, -9 lines 0 comments Download
M ui/views/controls/textfield/textfield_views_model.cc View 15 chunks +24 lines, -24 lines 0 comments Download
M ui/views/controls/textfield/textfield_views_model_unittest.cc View 19 chunks +62 lines, -62 lines 0 comments Download
M ui/views/examples/textfield_example.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/views/ime/input_method_bridge.h View 1 chunk +6 lines, -6 lines 0 comments Download
M ui/views/ime/input_method_bridge.cc View 1 2 3 4 1 chunk +6 lines, -6 lines 0 comments Download
M ui/views/touchui/touch_selection_controller_impl_unittest.cc View 10 chunks +20 lines, -20 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Ben Goodger (Google)
Just a move. rsesek: ui/base/range & ui/gfx/range sky: content/common apparently.
7 years, 3 months ago (2013-09-05 23:03:08 UTC) #1
sky
I'm not an owner for content/common. So, -sky +jam
7 years, 3 months ago (2013-09-05 23:20:45 UTC) #2
Ben Goodger (Google)
weird, the tool suggested you. -Ben On Thu, Sep 5, 2013 at 4:20 PM, <sky@chromium.org> ...
7 years, 3 months ago (2013-09-05 23:31:15 UTC) #3
jam
lgtm
7 years, 3 months ago (2013-09-06 05:04:35 UTC) #4
Robert Sesek
lgtm
7 years, 3 months ago (2013-09-06 15:05:16 UTC) #5
tfarina
Ben, this is also crbug.com/103304. Thanks for doing this!
7 years, 3 months ago (2013-09-06 16:36:08 UTC) #6
Ben Goodger (Google)
7 years, 3 months ago (2013-09-06 19:27:56 UTC) #7
jschuh
ipc security rubberstamp lgtm. just file moves and namespace changes.
7 years, 3 months ago (2013-09-06 19:30:38 UTC) #8
Ben Goodger (Google)
7 years, 3 months ago (2013-09-06 20:02:40 UTC) #9
Message was sent while issue was closed.
Committed patchset #7 manually as r221762 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698