third_party/WebKit/LayoutTests/media/mediasession/mediasession-constructor-hidden.html - Issue 2401013002: Make MediaSession per frame as an attribute of Navigator

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/media/mediasession/mediasession-constructor-hidden.html

Issue 2401013002: Make MediaSession per frame as an attribute of Navigator (Closed)

Patch Set: fixed tests Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/media/mediasession/mediaimage.html ('K') | « third_party/WebKit/LayoutTests/media/mediasession/mediasession-constructor-expected.txt ('k') | third_party/WebKit/LayoutTests/media/mediasession/mediasession-integration-test.html » ('j') | third_party/WebKit/LayoutTests/media/mediasession/mediasession-integration-test.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/media/mediasession/mediasession-constructor-hidden.html

diff --git a/third_party/WebKit/LayoutTests/fast/dom/canvas-fallback-focus-crash.html b/third_party/WebKit/LayoutTests/media/mediasession/mediasession-constructor-hidden.html

similarity index 52%

copy from third_party/WebKit/LayoutTests/fast/dom/canvas-fallback-focus-crash.html

copy to third_party/WebKit/LayoutTests/media/mediasession/mediasession-constructor-hidden.html

index a02efb0a2a890a292cc98a5ab9b0a426a05518f7..1bb4a95ead380c56a4e414d81efb6d18c5227f7e 100644

--- a/third_party/WebKit/LayoutTests/fast/dom/canvas-fallback-focus-crash.html

+++ b/third_party/WebKit/LayoutTests/media/mediasession/mediasession-constructor-hidden.html

@@ -1,11 +1,11 @@

<!DOCTYPE html>

+<title>MediaSession() constructor</title>

whywhat 2016/10/10 20:45:09 hm, do we need a test for that? I haven't found an

Zhiqiang Zhang (Slow) 2016/10/10 21:21:18 OK, I'll remove this test. These is a test for the

-<canvas>

- <object id="f"></object>

-</canvas>

test(function() {

- f.focus();

-}, "crbug.com/587263 focusing plugin object in canvas fallback may dereference nullptr");

+ assert_throws(new TypeError(), () => { var mediaSession = new MediaSession(); }, "Illegal constructor");

+});

</script>