Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: third_party/WebKit/LayoutTests/media/mediasession/mediaimage.html

Issue 2401013002: Make MediaSession per frame as an attribute of Navigator (Closed)
Patch Set: fixed tests Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/media/mediasession/mediaimage.html
diff --git a/third_party/WebKit/LayoutTests/media/mediasession/mediaimage.html b/third_party/WebKit/LayoutTests/media/mediasession/mediaimage.html
index dcf76e5f5db2783c7db52642014cee1a921341e2..68e06bc921c1aa6ce52ff2efabf30d1580bc3c48 100644
--- a/third_party/WebKit/LayoutTests/media/mediasession/mediaimage.html
+++ b/third_party/WebKit/LayoutTests/media/mediasession/mediaimage.html
@@ -3,46 +3,46 @@
<script src="../../resources/testharness.js"></script>
<script src="../../resources/testharnessreport.js"></script>
<script>
- console.warn("dummy log entry to avoid an empty -expected.txt in virtual/");
- test(function() {
- var image = new MediaImage({});
- assert_true(image != null);
+test(function() {
whywhat 2016/10/10 20:45:09 is this change accidental? seems unrelated from th
Zhiqiang Zhang (Slow) 2016/10/11 10:56:03 Aha! I found the indentation in this file is prett
whywhat 2016/10/11 14:58:33 Usually reformatting is done in separate cls since
Zhiqiang Zhang (Slow) 2016/10/11 16:59:05 OK, reverted the indenting.
+ var image = new MediaImage({});
+ assert_true(image != null);
mlamouri (slow - plz ping) 2016/10/10 20:30:34 `assert_not_equals(image, null)`?
Zhiqiang Zhang (Slow) 2016/10/11 10:56:03 Done.
- var exception = false;
- try {
- image = new MediaImage("foobar");
- } catch (e) {
- exception = true;
- }
- assert_true(exception);
+ var exception = false;
+ try {
+ image = new MediaImage("foobar");
+ } catch (e) {
+ exception = true;
+ }
+ assert_true(exception);
- exception = false;
- try {
- image = new MediaImage(42);
- } catch (e) {
- exception = true;
- }
- assert_true(exception);
- }, 'Test that MediaImage is constructed using a dictionary');
+ exception = false;
mlamouri (slow - plz ping) 2016/10/10 20:30:34 style: I might misunderstand the diff but is this
Zhiqiang Zhang (Slow) 2016/10/11 10:56:03 Done.
+ try {
+ image = new MediaImage(42);
+ } catch (e) {
+ exception = true;
+ }
mlamouri (slow - plz ping) 2016/10/10 20:30:34 ditto
Zhiqiang Zhang (Slow) 2016/10/11 10:56:03 Done.
+ assert_true(exception);
+}, 'Test that MediaImage is constructed using a dictionary');
-test (function() {
- var image = new MediaImage({
- src: 'foo', sizes: 'bar', type: 'plop'});
- assert_greater_than(image.src.indexOf('foo'), -1);
- assert_equals(image.sizes, 'bar');
- assert_equals(image.type, 'plop');
+test(function() {
+ var image = new MediaImage({
+ src: 'foo', sizes: 'bar', type: 'plop'});
+ assert_greater_than(image.src.indexOf('foo'), -1);
+ assert_equals(image.sizes, 'bar');
+ assert_equals(image.type, 'plop');
}, 'Test the different values allowed in MediaImage init dictionary');
test (function() {
- var image = new MediaImage({});
- assert_equals(image.src, document.URL);
- assert_equals(image.sizes, '');
- assert_equals(image.type, '');
+ var image = new MediaImage({});
+ assert_equals(image.src, document.URL);
+ assert_equals(image.sizes, '');
+ assert_equals(image.type, '');
}, 'Test the default values for MediaImage');
test (function() {
- var image = new MediaMetadata({ randomValueThatWillNotBeAdded: '... hopefully ;)' });
- assert_equals(image.randomValueThatWillNotBeAdded, undefined);
+ var image = new MediaMetadata({ randomValueThatWillNotBeAdded: '... hopefully ;)' });
+ assert_equals(image.randomValueThatWillNotBeAdded, undefined);
}, 'Test that passing unknown values to the dictionary is a no-op');
+
</script>

Powered by Google App Engine
This is Rietveld 408576698