third_party/WebKit/LayoutTests/media/mediasession/mediasession-constructor-hidden.html - Issue 2401013002: Make MediaSession per frame as an attribute of Navigator

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/media/mediasession/mediasession-constructor-hidden.html

Issue 2401013002: Make MediaSession per frame as an attribute of Navigator (Closed)

Patch Set: fixed tests Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

	2 <title>MediaSession() constructor</title>
	whywhat 2016/10/10 20:45:09 hm, do we need a test for that? I haven't found an hm, do we need a test for that? I haven't found any precedents in the code base. Adding a ctor would require API review and changing all the interface listed tests, right? Zhiqiang Zhang (Slow) 2016/10/10 21:21:18 OK, I'll remove this test. These is a test for the Show quoted text On 2016/10/10 20:45:09, whywhat wrote: > hm, do we need a test for that? I haven't found any precedents in the code base. > Adding a ctor would require API review and changing all the interface listed > tests, right? OK, I'll remove this test. These is a test for the exposed interfaces (global-interface-listing.html), and it should be caught by that.
2 <script src="../../resources/testharness.js"></script>	3 <script src="../../resources/testharness.js"></script>

3 <script src="../../resources/testharnessreport.js"></script>	4 <script src="../../resources/testharnessreport.js"></script>

4 <canvas>

5 <object id="f"></object>

6 </canvas>

7 <script>	5 <script>

	6

8 test(function() {	7 test(function() {

9 f.focus();	8 assert_throws(new TypeError(), () => { var mediaSession = new MediaSession(); }, "Illegal constructor");

10 }, "crbug.com/587263 focusing plugin object in canvas fallback may dereference n ullptr");	9 });

	10

11 </script>	11 </script>

OLD	NEW