Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Unified Diff: third_party/WebKit/Source/modules/permissions/PermissionStatus.h

Issue 2400903002: Clear PermissionStatus::m_service in pre-finalizer
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/permissions/PermissionStatus.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/permissions/PermissionStatus.h
diff --git a/third_party/WebKit/Source/modules/permissions/PermissionStatus.h b/third_party/WebKit/Source/modules/permissions/PermissionStatus.h
index e67c5bc5c29044bfddb66f0eb985a8a1e6430665..ed3e5d7207750c649ba57097e6358ab8a9e6218e 100644
--- a/third_party/WebKit/Source/modules/permissions/PermissionStatus.h
+++ b/third_party/WebKit/Source/modules/permissions/PermissionStatus.h
@@ -24,6 +24,7 @@ class PermissionStatus final : public EventTargetWithInlineData,
public ActiveScriptWrappable,
public ActiveDOMObject {
USING_GARBAGE_COLLECTED_MIXIN(PermissionStatus);
+ USING_PRE_FINALIZER(PermissionStatus, dispose);
DEFINE_WRAPPERTYPEINFO();
using MojoPermissionDescriptor = mojom::blink::PermissionDescriptorPtr;
@@ -37,7 +38,7 @@ class PermissionStatus final : public EventTargetWithInlineData,
static PermissionStatus* createAndListen(ExecutionContext*,
MojoPermissionStatus,
MojoPermissionDescriptor);
- ~PermissionStatus() override;
+ void dispose();
// EventTarget implementation.
const AtomicString& interfaceName() const override;
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/permissions/PermissionStatus.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698