Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Unified Diff: third_party/WebKit/Source/modules/permissions/PermissionStatus.cpp

Issue 2400903002: Clear PermissionStatus::m_service in pre-finalizer
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/modules/permissions/PermissionStatus.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/permissions/PermissionStatus.cpp
diff --git a/third_party/WebKit/Source/modules/permissions/PermissionStatus.cpp b/third_party/WebKit/Source/modules/permissions/PermissionStatus.cpp
index 71f9f8e0665966310008d755f143329ef3779c67..265cfcb54ccede3cdb9deb94ad54d380aff5fdc9 100644
--- a/third_party/WebKit/Source/modules/permissions/PermissionStatus.cpp
+++ b/third_party/WebKit/Source/modules/permissions/PermissionStatus.cpp
@@ -39,9 +39,11 @@ PermissionStatus::PermissionStatus(ExecutionContext* executionContext,
: ActiveScriptWrappable(this),
ActiveDOMObject(executionContext),
m_status(status),
- m_descriptor(std::move(descriptor)) {}
+ m_descriptor(std::move(descriptor)) {
+ ThreadState::current()->registerPreFinalizer(this);
+}
-PermissionStatus::~PermissionStatus() {
+void PermissionStatus::dispose() {
stopListening();
}
« no previous file with comments | « third_party/WebKit/Source/modules/permissions/PermissionStatus.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698