Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Side by Side Diff: third_party/WebKit/Source/modules/permissions/PermissionStatus.h

Issue 2400903002: Clear PermissionStatus::m_service in pre-finalizer
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/permissions/PermissionStatus.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef PermissionStatus_h 5 #ifndef PermissionStatus_h
6 #define PermissionStatus_h 6 #define PermissionStatus_h
7 7
8 #include "bindings/core/v8/ActiveScriptWrappable.h" 8 #include "bindings/core/v8/ActiveScriptWrappable.h"
9 #include "core/dom/ActiveDOMObject.h" 9 #include "core/dom/ActiveDOMObject.h"
10 #include "core/events/EventTarget.h" 10 #include "core/events/EventTarget.h"
11 #include "platform/heap/Handle.h" 11 #include "platform/heap/Handle.h"
12 #include "public/platform/modules/permissions/permission.mojom-blink.h" 12 #include "public/platform/modules/permissions/permission.mojom-blink.h"
13 #include "wtf/text/AtomicString.h" 13 #include "wtf/text/AtomicString.h"
14 #include "wtf/text/WTFString.h" 14 #include "wtf/text/WTFString.h"
15 15
16 namespace blink { 16 namespace blink {
17 17
18 class ExecutionContext; 18 class ExecutionContext;
19 class ScriptPromiseResolver; 19 class ScriptPromiseResolver;
20 20
21 // Expose the status of a given WebPermissionType for the current 21 // Expose the status of a given WebPermissionType for the current
22 // ExecutionContext. 22 // ExecutionContext.
23 class PermissionStatus final : public EventTargetWithInlineData, 23 class PermissionStatus final : public EventTargetWithInlineData,
24 public ActiveScriptWrappable, 24 public ActiveScriptWrappable,
25 public ActiveDOMObject { 25 public ActiveDOMObject {
26 USING_GARBAGE_COLLECTED_MIXIN(PermissionStatus); 26 USING_GARBAGE_COLLECTED_MIXIN(PermissionStatus);
27 USING_PRE_FINALIZER(PermissionStatus, dispose);
27 DEFINE_WRAPPERTYPEINFO(); 28 DEFINE_WRAPPERTYPEINFO();
28 29
29 using MojoPermissionDescriptor = mojom::blink::PermissionDescriptorPtr; 30 using MojoPermissionDescriptor = mojom::blink::PermissionDescriptorPtr;
30 using MojoPermissionStatus = mojom::blink::PermissionStatus; 31 using MojoPermissionStatus = mojom::blink::PermissionStatus;
31 32
32 public: 33 public:
33 static PermissionStatus* take(ScriptPromiseResolver*, 34 static PermissionStatus* take(ScriptPromiseResolver*,
34 MojoPermissionStatus, 35 MojoPermissionStatus,
35 MojoPermissionDescriptor); 36 MojoPermissionDescriptor);
36 37
37 static PermissionStatus* createAndListen(ExecutionContext*, 38 static PermissionStatus* createAndListen(ExecutionContext*,
38 MojoPermissionStatus, 39 MojoPermissionStatus,
39 MojoPermissionDescriptor); 40 MojoPermissionDescriptor);
40 ~PermissionStatus() override; 41 void dispose();
41 42
42 // EventTarget implementation. 43 // EventTarget implementation.
43 const AtomicString& interfaceName() const override; 44 const AtomicString& interfaceName() const override;
44 ExecutionContext* getExecutionContext() const override; 45 ExecutionContext* getExecutionContext() const override;
45 46
46 // ScriptWrappable implementation. 47 // ScriptWrappable implementation.
47 bool hasPendingActivity() const final; 48 bool hasPendingActivity() const final;
48 49
49 // ActiveDOMObject implementation. 50 // ActiveDOMObject implementation.
50 void suspend() override; 51 void suspend() override;
(...skipping 16 matching lines...) Expand all
67 void stopListening(); 68 void stopListening();
68 69
69 MojoPermissionStatus m_status; 70 MojoPermissionStatus m_status;
70 MojoPermissionDescriptor m_descriptor; 71 MojoPermissionDescriptor m_descriptor;
71 mojom::blink::PermissionServicePtr m_service; 72 mojom::blink::PermissionServicePtr m_service;
72 }; 73 };
73 74
74 } // namespace blink 75 } // namespace blink
75 76
76 #endif // PermissionStatus_h 77 #endif // PermissionStatus_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/permissions/PermissionStatus.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698