Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Side by Side Diff: third_party/WebKit/Source/modules/permissions/PermissionStatus.cpp

Issue 2400903002: Clear PermissionStatus::m_service in pre-finalizer
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/modules/permissions/PermissionStatus.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "modules/permissions/PermissionStatus.h" 5 #include "modules/permissions/PermissionStatus.h"
6 6
7 #include "bindings/core/v8/ScriptPromiseResolver.h" 7 #include "bindings/core/v8/ScriptPromiseResolver.h"
8 #include "core/dom/Document.h" 8 #include "core/dom/Document.h"
9 #include "core/events/Event.h" 9 #include "core/events/Event.h"
10 #include "modules/EventTargetModulesNames.h" 10 #include "modules/EventTargetModulesNames.h"
(...skipping 21 matching lines...) Expand all
32 permissionStatus->startListening(); 32 permissionStatus->startListening();
33 return permissionStatus; 33 return permissionStatus;
34 } 34 }
35 35
36 PermissionStatus::PermissionStatus(ExecutionContext* executionContext, 36 PermissionStatus::PermissionStatus(ExecutionContext* executionContext,
37 MojoPermissionStatus status, 37 MojoPermissionStatus status,
38 MojoPermissionDescriptor descriptor) 38 MojoPermissionDescriptor descriptor)
39 : ActiveScriptWrappable(this), 39 : ActiveScriptWrappable(this),
40 ActiveDOMObject(executionContext), 40 ActiveDOMObject(executionContext),
41 m_status(status), 41 m_status(status),
42 m_descriptor(std::move(descriptor)) {} 42 m_descriptor(std::move(descriptor)) {
43 ThreadState::current()->registerPreFinalizer(this);
44 }
43 45
44 PermissionStatus::~PermissionStatus() { 46 void PermissionStatus::dispose() {
45 stopListening(); 47 stopListening();
46 } 48 }
47 49
48 const AtomicString& PermissionStatus::interfaceName() const { 50 const AtomicString& PermissionStatus::interfaceName() const {
49 return EventTargetNames::PermissionStatus; 51 return EventTargetNames::PermissionStatus;
50 } 52 }
51 53
52 ExecutionContext* PermissionStatus::getExecutionContext() const { 54 ExecutionContext* PermissionStatus::getExecutionContext() const {
53 return ActiveDOMObject::getExecutionContext(); 55 return ActiveDOMObject::getExecutionContext();
54 } 56 }
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
110 ASSERT_NOT_REACHED(); 112 ASSERT_NOT_REACHED();
111 return "denied"; 113 return "denied";
112 } 114 }
113 115
114 DEFINE_TRACE(PermissionStatus) { 116 DEFINE_TRACE(PermissionStatus) {
115 EventTargetWithInlineData::trace(visitor); 117 EventTargetWithInlineData::trace(visitor);
116 ActiveDOMObject::trace(visitor); 118 ActiveDOMObject::trace(visitor);
117 } 119 }
118 120
119 } // namespace blink 121 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/modules/permissions/PermissionStatus.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698