keep only one typedef for the native drawing context

keep only one typedef for the native drawing context

This patch remove the NativeDrawingContext from ui/gfx/native_widget_types.h,
renames the PlatformSurface in skia/ext/platform_surface.h to NativeDrawingContext,
and updates the clients of gfx::NativeDrawingContext to the skia one.

BUG=76105
TEST=skia_unittests,printing_unittests
R=danakj@chromium.org,thestig@chromium.org,fmalita@chromium.org
TBR=sky@chromium.org

Committed: https://crrev.com/876d1e0bcb39165f149a93ae2db12d5cdfcb219d
Cr-Commit-Position: refs/heads/master@{#424585}

[tfarina, 2016-10-06 23:54:20]

The CQ bit was checked by tfarina@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-06 23:54:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danakj, 2016-10-07 00:11:41]

Looks like skia/ext/platform_surface.h should be renamed also.

[commit-bot: I haz the power, 2016-10-07 00:59:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-07 01:00:00]

Dry run: This issue passed the CQ dry run.

[tomhudson, 2016-10-07 06:10:14]

https://codereview.chromium.org/2400873002/diff/1/skia/ext/platform_surface.h
File skia/ext/platform_surface.h (right):

https://codereview.chromium.org/2400873002/diff/1/skia/ext/platform_surface.h...
skia/ext/platform_surface.h:29: typedef cairo_t* NativeDrawingContext;
Misspelled - this shouldn't build on Linux?

[tomhudson, 2016-10-07 06:12:34]

tomhudson@google.com changed reviewers:
+ tomhudson@google.com

[tomhudson, 2016-10-07 06:12:34]

https://codereview.chromium.org/2400873002/diff/1/skia/ext/platform_surface.h
File skia/ext/platform_surface.h (right):

https://codereview.chromium.org/2400873002/diff/1/skia/ext/platform_surface.h...
skia/ext/platform_surface.h:29: typedef cairo_t* NativeDrawingContext;
On 2016/10/07 06:10:14, tomhudson wrote:
> Misspelled - this shouldn't build on Linux?

Never mind, my laptop screen was dirty. No wonder the trybots passed.

[tfarina, 2016-10-07 07:48:43]

On 2016/10/07 00:11:41, danakj wrote:
> Looks like skia/ext/platform_surface.h should be renamed also.

What would you like it be renamed to? platform_types.h would be ok?

[danakj, 2016-10-07 18:43:32]

On 2016/10/07 07:48:43, tfarina wrote:
> On 2016/10/07 00:11:41, danakj wrote:
> > Looks like skia/ext/platform_surface.h should be renamed also.
> 
> What would you like it be renamed to? platform_types.h would be ok?

native_drawing_context.h would match the old naming but the new type.

[tfarina, 2016-10-07 19:38:51]

On 2016/10/07 18:43:32, danakj wrote:
> On 2016/10/07 07:48:43, tfarina wrote:
> > On 2016/10/07 00:11:41, danakj wrote:
> > > Looks like skia/ext/platform_surface.h should be renamed also.
> > 
> > What would you like it be renamed to? platform_types.h would be ok?
> 
> native_drawing_context.h would match the old naming but the new type.

Don't you mind that there is PlatformRect in there?

[danakj, 2016-10-07 21:37:55]

On Fri, Oct 7, 2016 at 12:38 PM, <tfarina@chromium.org> wrote:

> On 2016/10/07 18:43:32, danakj wrote:
> > On 2016/10/07 07:48:43, tfarina wrote:
> > > On 2016/10/07 00:11:41, danakj wrote:
> > > > Looks like skia/ext/platform_surface.h should be renamed also.
> > >
> > > What would you like it be renamed to? platform_types.h would be ok?
> >
> > native_drawing_context.h would match the old naming but the new type.
>
> Don't you mind that there is PlatformRect in there?
>

I don't know what to do with that one TBH.


>
> https://codereview.chromium.org/2400873002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[danakj, 2016-10-07 21:38:35]

On Fri, Oct 7, 2016 at 2:37 PM, <danakj@chromium.org> wrote:

> On Fri, Oct 7, 2016 at 12:38 PM, <tfarina@chromium.org> wrote:
>
>> On 2016/10/07 18:43:32, danakj wrote:
>> > On 2016/10/07 07:48:43, tfarina wrote:
>> > > On 2016/10/07 00:11:41, danakj wrote:
>> > > > Looks like skia/ext/platform_surface.h should be renamed also.
>> > >
>> > > What would you like it be renamed to? platform_types.h would be ok?
>> >
>> > native_drawing_context.h would match the old naming but the new type.
>>
>> Don't you mind that there is PlatformRect in there?
>>
>
> I don't know what to do with that one TBH.
>

Should probably be its own header but value:work ratio is not great.


>
>
>>
>> https://codereview.chromium.org/2400873002/
>>
>
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[tfarina, 2016-10-08 09:28:52]

The CQ bit was checked by tfarina@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-08 09:29:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tfarina, 2016-10-08 09:37:25]

Dana, apparently PlatformRect is unused. I kicked off a try to see if the
trybots confirm this.

If it is, and I'm hoping it is, the the road for renaming platform_surface.h to
native_drawing_context.h will be easier.

[commit-bot: I haz the power, 2016-10-08 10:33:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-08 10:33:47]

Dry run: This issue passed the CQ dry run.

[tfarina, 2016-10-08 12:18:05]

The CQ bit was checked by tfarina@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-08 12:18:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tfarina, 2016-10-08 13:01:17]

Dana, could you take another look?

[commit-bot: I haz the power, 2016-10-08 13:10:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-08 13:10:31]

Dry run: This issue passed the CQ dry run.

[danakj, 2016-10-10 20:37:22]

LGTM thanks!

[tfarina, 2016-10-11 10:07:35]

The CQ bit was checked by tfarina@chromium.org

[commit-bot: I haz the power, 2016-10-11 10:07:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-11 10:15:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-11 10:15:01]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[f(malita), 2016-10-11 12:48:05]

skia/ LGTM

[Lei Zhang, 2016-10-11 21:34:47]

printing/ lgtm

[tfarina, 2016-10-11 22:01:19]

Description was changed from

==========
keep only one typedef for the native drawing context

This patch remove the NativeDrawingContext from ui/gfx/native_widget_types.h,
renames the PlatformSurface in skia/ext/platform_surface.h to
NativeDrawingContext,
and updates the clients of gfx::NativeDrawingContext to the skia one.

BUG=76105
TEST=skia_unittests,printing_unittests
R=danakj@chromium.org,thestig@chromium.org,fmalita@chromium.org
==========

to

==========
keep only one typedef for the native drawing context

This patch remove the NativeDrawingContext from ui/gfx/native_widget_types.h,
renames the PlatformSurface in skia/ext/platform_surface.h to
NativeDrawingContext,
and updates the clients of gfx::NativeDrawingContext to the skia one.

BUG=76105
TEST=skia_unittests,printing_unittests
R=danakj@chromium.org,thestig@chromium.org,fmalita@chromium.org
TBR=sky@chromium.org
==========

[tfarina, 2016-10-11 22:01:19]

tfarina@chromium.org changed reviewers:
+ sky@chromium.org

[tfarina, 2016-10-11 22:02:20]

TBRing Scott for the minor changes in ui/base and ui/native_theme.

[tfarina, 2016-10-11 22:02:28]

The CQ bit was checked by tfarina@chromium.org

[commit-bot: I haz the power, 2016-10-11 22:02:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sky, 2016-10-11 23:09:43]

LGTM

[commit-bot: I haz the power, 2016-10-11 23:13:18]

Description was changed from

==========
keep only one typedef for the native drawing context

This patch remove the NativeDrawingContext from ui/gfx/native_widget_types.h,
renames the PlatformSurface in skia/ext/platform_surface.h to
NativeDrawingContext,
and updates the clients of gfx::NativeDrawingContext to the skia one.

BUG=76105
TEST=skia_unittests,printing_unittests
R=danakj@chromium.org,thestig@chromium.org,fmalita@chromium.org
TBR=sky@chromium.org
==========

to

==========
keep only one typedef for the native drawing context

This patch remove the NativeDrawingContext from ui/gfx/native_widget_types.h,
renames the PlatformSurface in skia/ext/platform_surface.h to
NativeDrawingContext,
and updates the clients of gfx::NativeDrawingContext to the skia one.

BUG=76105
TEST=skia_unittests,printing_unittests
R=danakj@chromium.org,thestig@chromium.org,fmalita@chromium.org
TBR=sky@chromium.org
==========

[commit-bot: I haz the power, 2016-10-11 23:13:19]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-11 23:15:33]

Description was changed from

==========
keep only one typedef for the native drawing context

This patch remove the NativeDrawingContext from ui/gfx/native_widget_types.h,
renames the PlatformSurface in skia/ext/platform_surface.h to
NativeDrawingContext,
and updates the clients of gfx::NativeDrawingContext to the skia one.

BUG=76105
TEST=skia_unittests,printing_unittests
R=danakj@chromium.org,thestig@chromium.org,fmalita@chromium.org
TBR=sky@chromium.org
==========

to

==========
keep only one typedef for the native drawing context

This patch remove the NativeDrawingContext from ui/gfx/native_widget_types.h,
renames the PlatformSurface in skia/ext/platform_surface.h to
NativeDrawingContext,
and updates the clients of gfx::NativeDrawingContext to the skia one.

BUG=76105
TEST=skia_unittests,printing_unittests
R=danakj@chromium.org,thestig@chromium.org,fmalita@chromium.org
TBR=sky@chromium.org

Committed: https://crrev.com/876d1e0bcb39165f149a93ae2db12d5cdfcb219d
Cr-Commit-Position: refs/heads/master@{#424585}
==========

[commit-bot: I haz the power, 2016-10-11 23:15:35]

Patchset 3 (id:??) landed as
https://crrev.com/876d1e0bcb39165f149a93ae2db12d5cdfcb219d
Cr-Commit-Position: refs/heads/master@{#424585}