Convert CPDFSDK_PageView to have a CPDFSDK_FormFillEnvironment

Convert CPDFSDK_PageView to have a CPDFSDK_FormFillEnvironment

This CL changes CPDFSDK_PageView to have a CPDFSDK_FormFillEnvironment instead
of a CPDFSDK_Document.

Committed: https://pdfium.googlesource.com/pdfium/+/b402b1738d665561dd1bb7ffba0c3f3d49425086

[dsinclair, 2016-10-06 14:50:52]

The CQ bit was checked by dsinclair@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-06 14:51:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 15:02:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-06 15:02:31]

Dry run: This issue passed the CQ dry run.

[dsinclair, 2016-10-06 15:05:06]

dsinclair@chromium.org changed reviewers:
+ tsepez@chromium.org, weili@chromium.org

[dsinclair, 2016-10-06 15:05:06]

PTAL.

[Tom Sepez, 2016-10-06 18:46:28]

lgtm

https://codereview.chromium.org/2400673002/diff/1/fpdfsdk/cpdfsdk_document.cpp
File fpdfsdk/cpdfsdk_document.cpp (right):

https://codereview.chromium.org/2400673002/diff/1/fpdfsdk/cpdfsdk_document.cp...
fpdfsdk/cpdfsdk_document.cpp:67: new CPDFSDK_PageView(this->GetEnv(),
pUnderlyingPage);
nit: just GetEnv()

https://codereview.chromium.org/2400673002/diff/1/fpdfsdk/cpdfsdk_pageview.h
File fpdfsdk/cpdfsdk_pageview.h (right):

https://codereview.chromium.org/2400673002/diff/1/fpdfsdk/cpdfsdk_pageview.h#...
fpdfsdk/cpdfsdk_pageview.h:62: CPDFSDK_FormFillEnvironment* GetFormFillEnv() {
return m_pFormFillEnv; }
nit: const method?

https://codereview.chromium.org/2400673002/diff/1/fpdfsdk/cpdfsdk_widget.cpp
File fpdfsdk/cpdfsdk_widget.cpp (right):

https://codereview.chromium.org/2400673002/diff/1/fpdfsdk/cpdfsdk_widget.cpp#...
fpdfsdk/cpdfsdk_widget.cpp:1836:
pPageView->GetFormFillEnv()->GetSDKDocument()->GetXFADocument();
nit: use local?

https://codereview.chromium.org/2400673002/diff/1/fpdfsdk/cpdfsdk_xfawidgetha...
File fpdfsdk/cpdfsdk_xfawidgethandler.cpp (right):

https://codereview.chromium.org/2400673002/diff/1/fpdfsdk/cpdfsdk_xfawidgetha...
fpdfsdk/cpdfsdk_xfawidgethandler.cpp:117: if
(!pPageView->GetFormFillEnv()->GetSDKDocument())
really want local here.

https://codereview.chromium.org/2400673002/diff/1/fpdfsdk/cpdfsdk_xfawidgetha...
fpdfsdk/cpdfsdk_xfawidgethandler.cpp:345: if
(!pPageView->GetFormFillEnv()->GetSDKDocument())
ditto

[dsinclair, 2016-10-06 19:32:55]

https://codereview.chromium.org/2400673002/diff/1/fpdfsdk/cpdfsdk_document.cpp
File fpdfsdk/cpdfsdk_document.cpp (right):

https://codereview.chromium.org/2400673002/diff/1/fpdfsdk/cpdfsdk_document.cp...
fpdfsdk/cpdfsdk_document.cpp:67: new CPDFSDK_PageView(this->GetEnv(),
pUnderlyingPage);
On 2016/10/06 18:46:28, Tom Sepez wrote:
> nit: just GetEnv()

Done.

https://codereview.chromium.org/2400673002/diff/1/fpdfsdk/cpdfsdk_pageview.h
File fpdfsdk/cpdfsdk_pageview.h (right):

https://codereview.chromium.org/2400673002/diff/1/fpdfsdk/cpdfsdk_pageview.h#...
fpdfsdk/cpdfsdk_pageview.h:62: CPDFSDK_FormFillEnvironment* GetFormFillEnv() {
return m_pFormFillEnv; }
On 2016/10/06 18:46:28, Tom Sepez wrote:
> nit: const method?

Done.

https://codereview.chromium.org/2400673002/diff/1/fpdfsdk/cpdfsdk_widget.cpp
File fpdfsdk/cpdfsdk_widget.cpp (right):

https://codereview.chromium.org/2400673002/diff/1/fpdfsdk/cpdfsdk_widget.cpp#...
fpdfsdk/cpdfsdk_widget.cpp:1836:
pPageView->GetFormFillEnv()->GetSDKDocument()->GetXFADocument();
On 2016/10/06 18:46:28, Tom Sepez wrote:
> nit: use local?

Done.

https://codereview.chromium.org/2400673002/diff/1/fpdfsdk/cpdfsdk_xfawidgetha...
File fpdfsdk/cpdfsdk_xfawidgethandler.cpp (right):

https://codereview.chromium.org/2400673002/diff/1/fpdfsdk/cpdfsdk_xfawidgetha...
fpdfsdk/cpdfsdk_xfawidgethandler.cpp:117: if
(!pPageView->GetFormFillEnv()->GetSDKDocument())
On 2016/10/06 18:46:28, Tom Sepez wrote:
> really want local here.


Added one for the FormFillEnv.

https://codereview.chromium.org/2400673002/diff/1/fpdfsdk/cpdfsdk_xfawidgetha...
fpdfsdk/cpdfsdk_xfawidgethandler.cpp:345: if
(!pPageView->GetFormFillEnv()->GetSDKDocument())
On 2016/10/06 18:46:28, Tom Sepez wrote:
> ditto

Done.

[dsinclair, 2016-10-11 16:13:30]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-10-11 16:13:31]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/2400673002/#ps40001
(title: "Rebase to master")

[commit-bot: I haz the power, 2016-10-11 16:13:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-11 16:26:34]

Description was changed from

==========
Convert CPDFSDK_PageView to have a CPDFSDK_FormFillEnvironment

This CL changes CPDFSDK_PageView to have a CPDFSDK_FormFillEnvironment instead
of a CPDFSDK_Document.
==========

to

==========
Convert CPDFSDK_PageView to have a CPDFSDK_FormFillEnvironment

This CL changes CPDFSDK_PageView to have a CPDFSDK_FormFillEnvironment instead
of a CPDFSDK_Document.

Committed:
https://pdfium.googlesource.com/pdfium/+/b402b1738d665561dd1bb7ffba0c3f3d4942...
==========

[commit-bot: I haz the power, 2016-10-11 16:26:35]

Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/b402b1738d665561dd1bb7ffba0c3f3d4942...