Convert CPDFSDK_InterForm to take a CPDFSDK_FormFillEnvironment

Convert CPDFSDK_InterForm to take a CPDFSDK_FormFillEnvironment

This CL removes CPDFSDK_Document from CPDFSDK_InterForm and has it work with
a CPDFSDK_FormFillEnvironment.

Committed: https://pdfium.googlesource.com/pdfium/+/690c033e86b34f7a9c3d4be15759c63ef9360217

[dsinclair, 2016-10-06 14:17:53]

The CQ bit was checked by dsinclair@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-06 14:18:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 14:29:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-06 14:29:31]

Dry run: This issue passed the CQ dry run.

[dsinclair, 2016-10-06 14:35:47]

dsinclair@chromium.org changed reviewers:
+ tsepez@chromium.org, weili@chromium.org

[dsinclair, 2016-10-06 14:35:47]

PTAL.

[Tom Sepez, 2016-10-06 18:42:06]

https://codereview.chromium.org/2397723005/diff/1/fpdfsdk/cpdfsdk_document.cpp
File fpdfsdk/cpdfsdk_document.cpp (right):

https://codereview.chromium.org/2397723005/diff/1/fpdfsdk/cpdfsdk_document.cp...
fpdfsdk/cpdfsdk_document.cpp:166: return m_pInterForm.get();
nit: this-> is redundant, just GetEnv()

https://codereview.chromium.org/2397723005/diff/1/fpdfsdk/cpdfsdk_interform.cpp
File fpdfsdk/cpdfsdk_interform.cpp (right):

https://codereview.chromium.org/2397723005/diff/1/fpdfsdk/cpdfsdk_interform.c...
fpdfsdk/cpdfsdk_interform.cpp:102: CPDF_Document* pDocument =
m_pFormFillEnv->GetSDKDocument()->GetPDFDocument();
nit: maybe want a local for the sdk doc, couple places below too.

https://codereview.chromium.org/2397723005/diff/1/fpdfsdk/javascript/Field.cpp
File fpdfsdk/javascript/Field.cpp (right):

https://codereview.chromium.org/2397723005/diff/1/fpdfsdk/javascript/Field.cp...
fpdfsdk/javascript/Field.cpp:301: ->GetSDKDocument()
is the document invariant across the all widgets?  Is there another way to get
it without all this work in every loop iteration?

[dsinclair, 2016-10-06 19:21:23]

https://codereview.chromium.org/2397723005/diff/1/fpdfsdk/cpdfsdk_document.cpp
File fpdfsdk/cpdfsdk_document.cpp (right):

https://codereview.chromium.org/2397723005/diff/1/fpdfsdk/cpdfsdk_document.cp...
fpdfsdk/cpdfsdk_document.cpp:166: return m_pInterForm.get();
On 2016/10/06 18:42:06, Tom Sepez wrote:
> nit: this-> is redundant, just GetEnv()

Done.

https://codereview.chromium.org/2397723005/diff/1/fpdfsdk/cpdfsdk_interform.cpp
File fpdfsdk/cpdfsdk_interform.cpp (right):

https://codereview.chromium.org/2397723005/diff/1/fpdfsdk/cpdfsdk_interform.c...
fpdfsdk/cpdfsdk_interform.cpp:102: CPDF_Document* pDocument =
m_pFormFillEnv->GetSDKDocument()->GetPDFDocument();
On 2016/10/06 18:42:06, Tom Sepez wrote:
> nit: maybe want a local for the sdk doc, couple places below too.


I've been avoiding that. The goal is that ->GetSDKDocument() will just be
removed in the final CL as CPDFSDK_FormFillEnvironment and CPDFSDK_Document
should become the same object at that point.

Not having the local means I can just go through and remove all the method
calls.

https://codereview.chromium.org/2397723005/diff/1/fpdfsdk/javascript/Field.cpp
File fpdfsdk/javascript/Field.cpp (right):

https://codereview.chromium.org/2397723005/diff/1/fpdfsdk/javascript/Field.cp...
fpdfsdk/javascript/Field.cpp:301: ->GetSDKDocument()
On 2016/10/06 18:42:06, Tom Sepez wrote:
> is the document invariant across the all widgets?  Is there another way to get
> it without all this work in every loop iteration?


a document has a single InterForm, but I haven't determined if all widgets have
to be in the same document. There is other code which makes it seem that we can
have different documents in the CJS_Runtime and the CJS_Context. Which also
seems wonky to me.

I'm putting a TODO here to figure this out in the future.

[dsinclair, 2016-10-11 12:50:32]

The CQ bit was checked by dsinclair@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-11 12:50:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-11 13:03:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-11 13:03:50]

Dry run: This issue passed the CQ dry run.

[dsinclair, 2016-10-11 14:05:45]

ping

[Tom Sepez, 2016-10-11 16:11:52]

lgtm

https://codereview.chromium.org/2397723005/diff/1/fpdfsdk/cpdfsdk_interform.cpp
File fpdfsdk/cpdfsdk_interform.cpp (right):

https://codereview.chromium.org/2397723005/diff/1/fpdfsdk/cpdfsdk_interform.c...
fpdfsdk/cpdfsdk_interform.cpp:102: CPDF_Document* pDocument =
m_pFormFillEnv->GetSDKDocument()->GetPDFDocument();
On 2016/10/06 19:21:23, dsinclair wrote:
> On 2016/10/06 18:42:06, Tom Sepez wrote:
> > nit: maybe want a local for the sdk doc, couple places below too.
> 
> 
> I've been avoiding that. The goal is that ->GetSDKDocument() will just be
> removed in the final CL as CPDFSDK_FormFillEnvironment and CPDFSDK_Document
> should become the same object at that point.
> 
> Not having the local means I can just go through and remove all the method
> calls.

Acknowledged.

[dsinclair, 2016-10-11 16:12:44]

The CQ bit was checked by dsinclair@chromium.org

[commit-bot: I haz the power, 2016-10-11 16:12:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-11 16:13:04]

Description was changed from

==========
Convert CPDFSDK_InterForm to take a CPDFSDK_FormFillEnvironment

This CL removes CPDFSDK_Document from CPDFSDK_InterForm and has it work with
a CPDFSDK_FormFillEnvironment.
==========

to

==========
Convert CPDFSDK_InterForm to take a CPDFSDK_FormFillEnvironment

This CL removes CPDFSDK_Document from CPDFSDK_InterForm and has it work with
a CPDFSDK_FormFillEnvironment.

Committed:
https://pdfium.googlesource.com/pdfium/+/690c033e86b34f7a9c3d4be15759c63ef936...
==========

[commit-bot: I haz the power, 2016-10-11 16:13:05]

Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/690c033e86b34f7a9c3d4be15759c63ef936...