Chromium Code Reviews

Issue 2397723005: Convert CPDFSDK_InterForm to take a CPDFSDK_FormFillEnvironment (Closed)

Created:
4 years, 2 months ago by dsinclair
Modified:
4 years, 2 months ago
Reviewers:
Tom Sepez, Wei Li
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Convert CPDFSDK_InterForm to take a CPDFSDK_FormFillEnvironment This CL removes CPDFSDK_Document from CPDFSDK_InterForm and has it work with a CPDFSDK_FormFillEnvironment. Committed: https://pdfium.googlesource.com/pdfium/+/690c033e86b34f7a9c3d4be15759c63ef9360217

Patch Set 1 #

Total comments: 7

Patch Set 2 : Review feedback #

Patch Set 3 : Rebase to master #

Unified diffs Side-by-side diffs Stats (+57 lines, -68 lines)
M fpdfsdk/cpdfsdk_document.cpp View 1 chunk +1 line, -1 line 0 comments
M fpdfsdk/cpdfsdk_interform.h View 3 chunks +4 lines, -4 lines 0 comments
M fpdfsdk/cpdfsdk_interform.cpp View 14 chunks +37 lines, -42 lines 0 comments
M fpdfsdk/cpdfsdk_widget.cpp View 5 chunks +6 lines, -17 lines 0 comments
M fpdfsdk/javascript/Field.cpp View 2 chunks +9 lines, -4 lines 0 comments

Dependent Patchsets:

Messages

Total messages: 18 (11 generated)
dsinclair
PTAL.
4 years, 2 months ago (2016-10-06 14:35:47 UTC) #6
Tom Sepez
https://codereview.chromium.org/2397723005/diff/1/fpdfsdk/cpdfsdk_document.cpp File fpdfsdk/cpdfsdk_document.cpp (right): https://codereview.chromium.org/2397723005/diff/1/fpdfsdk/cpdfsdk_document.cpp#newcode166 fpdfsdk/cpdfsdk_document.cpp:166: return m_pInterForm.get(); nit: this-> is redundant, just GetEnv() https://codereview.chromium.org/2397723005/diff/1/fpdfsdk/cpdfsdk_interform.cpp ...
4 years, 2 months ago (2016-10-06 18:42:06 UTC) #7
dsinclair
https://codereview.chromium.org/2397723005/diff/1/fpdfsdk/cpdfsdk_document.cpp File fpdfsdk/cpdfsdk_document.cpp (right): https://codereview.chromium.org/2397723005/diff/1/fpdfsdk/cpdfsdk_document.cpp#newcode166 fpdfsdk/cpdfsdk_document.cpp:166: return m_pInterForm.get(); On 2016/10/06 18:42:06, Tom Sepez wrote: > ...
4 years, 2 months ago (2016-10-06 19:21:23 UTC) #8
dsinclair
ping
4 years, 2 months ago (2016-10-11 14:05:45 UTC) #13
Tom Sepez
lgtm https://codereview.chromium.org/2397723005/diff/1/fpdfsdk/cpdfsdk_interform.cpp File fpdfsdk/cpdfsdk_interform.cpp (right): https://codereview.chromium.org/2397723005/diff/1/fpdfsdk/cpdfsdk_interform.cpp#newcode102 fpdfsdk/cpdfsdk_interform.cpp:102: CPDF_Document* pDocument = m_pFormFillEnv->GetSDKDocument()->GetPDFDocument(); On 2016/10/06 19:21:23, dsinclair ...
4 years, 2 months ago (2016-10-11 16:11:52 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2397723005/40001
4 years, 2 months ago (2016-10-11 16:12:46 UTC) #16
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 16:13:05 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/690c033e86b34f7a9c3d4be15759c63ef936...

Powered by Google App Engine