Convert Field to use CPDFSDK_FormFillEnvironment

Convert Field to use CPDFSDK_FormFillEnvironment

This CL changes Field from using a CPDFSDK_Document to using a
CPDFSDK_FormFillEnvironment.

Committed: https://pdfium.googlesource.com/pdfium/+/3a7741a2d9391fdbc54900695a980344dddf1692

[dsinclair, 2016-10-06 15:14:56]

The CQ bit was checked by dsinclair@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-06 15:15:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dsinclair, 2016-10-06 15:15:51]

dsinclair@chromium.org changed reviewers:
+ tsepez@chromium.org, weili@chromium.org

[dsinclair, 2016-10-06 15:15:52]

PTAL.

[commit-bot: I haz the power, 2016-10-06 15:27:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-06 15:27:50]

Dry run: This issue passed the CQ dry run.

[Tom Sepez, 2016-10-06 18:57:45]

https://codereview.chromium.org/2400443005/diff/1/fpdfsdk/javascript/Field.h
File fpdfsdk/javascript/Field.h (right):

https://codereview.chromium.org/2400443005/diff/1/fpdfsdk/javascript/Field.h#...
fpdfsdk/javascript/Field.h:465: CPDFSDK_FormFillEnvironment::ObservedPtr
m_pFormFillEnv;
do the document and the FFE have the same lifetime, so that this is cleared when
the document is destroyed?

[dsinclair, 2016-10-06 19:38:04]

https://codereview.chromium.org/2400443005/diff/1/fpdfsdk/javascript/Field.h
File fpdfsdk/javascript/Field.h (right):

https://codereview.chromium.org/2400443005/diff/1/fpdfsdk/javascript/Field.h#...
fpdfsdk/javascript/Field.h:465: CPDFSDK_FormFillEnvironment::ObservedPtr
m_pFormFillEnv;
On 2016/10/06 18:57:45, Tom Sepez wrote:
> do the document and the FFE have the same lifetime, so that this is cleared
when
> the document is destroyed?


The CPDFSDK_Document is created in the CPDFSDK_FormFillEnvironment constructor
as a std::unique_ptr. There is no setter method, and it will be freed when the
CPDFSDK_FormFillEnvironment destructor runs.

[dsinclair, 2016-10-11 14:06:04]

ping.

[Tom Sepez, 2016-10-11 16:12:57]

lgtm

[dsinclair, 2016-10-11 17:19:34]

The CQ bit was checked by dsinclair@chromium.org

[commit-bot: I haz the power, 2016-10-11 17:19:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-11 17:39:51]

Description was changed from

==========
Convert Field to use CPDFSDK_FormFillEnvironment

This CL changes Field from using a CPDFSDK_Document to using a
CPDFSDK_FormFillEnvironment.
==========

to

==========
Convert Field to use CPDFSDK_FormFillEnvironment

This CL changes Field from using a CPDFSDK_Document to using a
CPDFSDK_FormFillEnvironment.

Committed:
https://pdfium.googlesource.com/pdfium/+/3a7741a2d9391fdbc54900695a980344dddf...
==========

[commit-bot: I haz the power, 2016-10-11 17:39:52]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/3a7741a2d9391fdbc54900695a980344dddf...