Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 2399943002: Remove CPDFSDK_Document from IJS_Context (Closed)

Created:
4 years, 2 months ago by dsinclair
Modified:
4 years, 2 months ago
Reviewers:
Tom Sepez, Wei Li
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove CPDFSDK_Document from IJS_Context This CL converts the IJS_Context and implementations over to use CPDFSDK_FormFillEnvironment instead of CPDFSDK_Document. Committed: https://pdfium.googlesource.com/pdfium/+/4526faf9d62b64729a232c20ada67690f590abd2

Patch Set 1 #

Patch Set 2 : fixes #

Total comments: 1

Patch Set 3 : Update non-v8 build #

Patch Set 4 : Rebase to master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+163 lines, -169 lines) Patch
M fpdfsdk/fsdk_actionhandler.cpp View 3 chunks +15 lines, -15 lines 0 comments Download
M fpdfsdk/javascript/Document.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/javascript/JS_EventHandler.h View 1 4 chunks +16 lines, -16 lines 0 comments Download
M fpdfsdk/javascript/JS_EventHandler.cpp View 1 8 chunks +45 lines, -47 lines 0 comments Download
M fpdfsdk/javascript/JS_Runtime_Stub.cpp View 1 2 2 chunks +14 lines, -13 lines 0 comments Download
M fpdfsdk/javascript/PublicMethods.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/javascript/app.cpp View 1 6 chunks +14 lines, -14 lines 0 comments Download
M fpdfsdk/javascript/cjs_context.h View 2 chunks +14 lines, -15 lines 0 comments Download
M fpdfsdk/javascript/cjs_context.cpp View 4 chunks +27 lines, -31 lines 0 comments Download
M fpdfsdk/javascript/ijs_context.h View 3 chunks +14 lines, -14 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 10 (5 generated)
dsinclair
PTAL. https://codereview.chromium.org/2399943002/diff/20001/fpdfsdk/javascript/app.cpp File fpdfsdk/javascript/app.cpp (right): https://codereview.chromium.org/2399943002/diff/20001/fpdfsdk/javascript/app.cpp#newcode226 fpdfsdk/javascript/app.cpp:226: if (pDoc == pCurDoc) { I don't really ...
4 years, 2 months ago (2016-10-06 19:03:34 UTC) #4
dsinclair
ping.
4 years, 2 months ago (2016-10-11 14:06:17 UTC) #5
Tom Sepez
lgtm
4 years, 2 months ago (2016-10-11 16:15:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2399943002/60001
4 years, 2 months ago (2016-10-11 17:41:57 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 17:54:52 UTC) #10
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://pdfium.googlesource.com/pdfium/+/4526faf9d62b64729a232c20ada67690f590...

Powered by Google App Engine
This is Rietveld 408576698