Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1091)

Issue 2400393003: [Autofill] Close mojo interface bindings of autofill/password agent in time. (Closed)

Created:
4 years, 2 months ago by leonhsl(Using Gerrit)
Modified:
4 years, 2 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

[Autofill] Close mojo interface bindings of autofill/password agent in time. As for AutofillAgent, Password{Autofill,Generation}Agent, their destructions are asynchronous with destructions of corresponding render frame. Thus, even after corresponding render frame has been deleted, they can still keep alive for some while and still able to receive mojo messages which maybe lead to use-after-delete access on the render frame. To solve above problem, this CL closes the mojo interface bindings immediatelly when render frame got destroyed. BUG=641156 Review-Url: https://codereview.chromium.org/2320993002 Cr-Commit-Position: refs/heads/master@{#417286} (cherry picked from commit 7e8c85b79831bb59427ffc5b229bc08470f619ef) Committed: https://chromium.googlesource.com/chromium/src/+/2524a5f430bcc8cbc1e8d0c47c5047ba696c7f04

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M components/autofill/content/renderer/autofill_agent.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/autofill/content/renderer/password_autofill_agent.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/autofill/content/renderer/password_generation_agent.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
leonhsl(Using Gerrit)
Committed patchset #1 (id:1) manually as 2524a5f430bcc8cbc1e8d0c47c5047ba696c7f04.
4 years, 2 months ago (2016-10-08 02:43:03 UTC) #2
ssid
4 years, 2 months ago (2016-10-10 17:16:31 UTC) #3
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2409663002/ by ssid@chromium.org.

The reason for reverting is: All official builds fail to compile.
BUG=654178, 654475.

Powered by Google App Engine
This is Rietveld 408576698