Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Side by Side Diff: components/autofill/content/renderer/password_autofill_agent.cc

Issue 2400393003: [Autofill] Close mojo interface bindings of autofill/password agent in time. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/autofill/content/renderer/password_autofill_agent.h" 5 #include "components/autofill/content/renderer/password_autofill_agent.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <memory> 9 #include <memory>
10 #include <string> 10 #include <string>
(...skipping 1135 matching lines...) Expand 10 before | Expand all | Expand 10 after
1146 // we will never get to finish the load. 1146 // we will never get to finish the load.
1147 Send(new AutofillHostMsg_PasswordFormSubmitted(routing_id(), 1147 Send(new AutofillHostMsg_PasswordFormSubmitted(routing_id(),
1148 *submitted_form)); 1148 *submitted_form));
1149 provisionally_saved_form_.reset(); 1149 provisionally_saved_form_.reset();
1150 } else if (logger) { 1150 } else if (logger) {
1151 logger->LogMessage(Logger::STRING_FORM_IS_NOT_PASSWORD); 1151 logger->LogMessage(Logger::STRING_FORM_IS_NOT_PASSWORD);
1152 } 1152 }
1153 } 1153 }
1154 1154
1155 void PasswordAutofillAgent::OnDestruct() { 1155 void PasswordAutofillAgent::OnDestruct() {
1156 binding_.Close();
1156 base::ThreadTaskRunnerHandle::Get()->DeleteSoon(FROM_HERE, this); 1157 base::ThreadTaskRunnerHandle::Get()->DeleteSoon(FROM_HERE, this);
1157 } 1158 }
1158 1159
1159 void PasswordAutofillAgent::DidStartProvisionalLoad() { 1160 void PasswordAutofillAgent::DidStartProvisionalLoad() {
1160 std::unique_ptr<RendererSavePasswordProgressLogger> logger; 1161 std::unique_ptr<RendererSavePasswordProgressLogger> logger;
1161 if (logging_state_active_) { 1162 if (logging_state_active_) {
1162 logger.reset(new RendererSavePasswordProgressLogger(this, routing_id())); 1163 logger.reset(new RendererSavePasswordProgressLogger(this, routing_id()));
1163 logger->LogMessage(Logger::STRING_DID_START_PROVISIONAL_LOAD_METHOD); 1164 logger->LogMessage(Logger::STRING_DID_START_PROVISIONAL_LOAD_METHOD);
1164 } 1165 }
1165 1166
(...skipping 327 matching lines...) Expand 10 before | Expand all | Expand 10 after
1493 !(provisionally_saved_form_->password_value.empty() && 1494 !(provisionally_saved_form_->password_value.empty() &&
1494 provisionally_saved_form_->new_password_value.empty()); 1495 provisionally_saved_form_->new_password_value.empty());
1495 } 1496 }
1496 1497
1497 const mojom::AutofillDriverPtr& PasswordAutofillAgent::GetAutofillDriver() { 1498 const mojom::AutofillDriverPtr& PasswordAutofillAgent::GetAutofillDriver() {
1498 DCHECK(autofill_agent_); 1499 DCHECK(autofill_agent_);
1499 return autofill_agent_->GetAutofillDriver(); 1500 return autofill_agent_->GetAutofillDriver();
1500 } 1501 }
1501 1502
1502 } // namespace autofill 1503 } // namespace autofill
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698