Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 2320993002: [Autofill] Close mojo interface bindings of autofill/password agent in time. (Closed)

Created:
4 years, 3 months ago by leonhsl(Using Gerrit)
Modified:
4 years, 3 months ago
Reviewers:
vabr (Chromium)
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, vabr+watchlistpasswordmanager_chromium.org, rouslan+autofill_chromium.org, jam, browser-components-watch_chromium.org, jdonnelly+autofillwatch_chromium.org, darin-cc_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org, gcasto+watchlist_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Autofill] Close mojo interface bindings of autofill/password agent in time. As for AutofillAgent, Password{Autofill,Generation}Agent, their destructions are asynchronous with destructions of corresponding render frame. Thus, even after corresponding render frame has been deleted, they can still keep alive for some while and still able to receive mojo messages which maybe lead to use-after-delete access on the render frame. To solve above problem, this CL closes the mojo interface bindings immediatelly when render frame got destroyed. BUG=641156 Committed: https://crrev.com/7e8c85b79831bb59427ffc5b229bc08470f619ef Cr-Commit-Position: refs/heads/master@{#417286}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M components/autofill/content/renderer/autofill_agent.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/autofill/content/renderer/password_autofill_agent.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/autofill/content/renderer/password_generation_agent.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
leonhsl(Using Gerrit)
I suppose this CL should be able to solve bug 641156, could we just land ...
4 years, 3 months ago (2016-09-08 12:24:05 UTC) #4
vabr (Chromium)
LGTM, this looks like a very good idea! Thanks! Vaclav
4 years, 3 months ago (2016-09-08 12:26:25 UTC) #5
leonhsl(Using Gerrit)
On 2016/09/08 12:26:25, vabr (Chromium) wrote: > LGTM, this looks like a very good idea! ...
4 years, 3 months ago (2016-09-08 14:20:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2320993002/1
4 years, 3 months ago (2016-09-08 14:21:07 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-08 14:25:05 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 14:27:24 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7e8c85b79831bb59427ffc5b229bc08470f619ef
Cr-Commit-Position: refs/heads/master@{#417286}

Powered by Google App Engine
This is Rietveld 408576698