Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Issue 2399633002: Store physical location in LayoutTableRow, just like in all other objects. (Closed)

Created:
4 years, 2 months ago by mstensho (USE GERRIT)
Modified:
4 years, 2 months ago
Reviewers:
dgrogan, Xianzhu
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Store physical location in LayoutTableRow, just like in all other objects. BUG=652496 Committed: https://crrev.com/c41f39761c9b69b90d0225ce55d65d1272ebf419 Cr-Commit-Position: refs/heads/master@{#423701}

Patch Set 1 #

Patch Set 2 : Rebaseline #

Patch Set 3 : Back out unintended png change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+194 lines, -198 lines) Patch
M third_party/WebKit/LayoutTests/fast/table/border-collapsing/equal-precedence-resolution-vertical-expected.txt View 1 6 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/table/growCellForImageQuirk-vertical-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/table-writing-modes-h-expected.txt View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/table-writing-modes-v-expected.txt View 1 2 chunks +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/android/fast/css/h1-in-section-elements-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/android/fast/overflow/overflow-rtl-vertical-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/android/fast/table/027-vertical-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/android/fast/table/028-vertical-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/android/fast/table/038-vertical-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/android/fast/table/040-vertical-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/android/fast/table/auto-with-percent-height-vertical-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/android/fast/table/border-collapsing/001-vertical-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/android/fast/table/border-collapsing/003-vertical-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/android/fast/table/border-collapsing/004-vertical-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/android/fast/table/border-collapsing/rtl-border-collapsing-vertical-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/android/fast/table/colspanMinWidth-vertical-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/android/fast/table/growCellForImageQuirk-vertical-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/android/fast/table/rowspan-paint-order-vertical-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/android/fast/writing-mode/vertical-align-table-baseline-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/android/paint/invalidation/table-writing-modes-h-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/android/paint/invalidation/table-writing-modes-v-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/css/h1-in-section-elements-expected.txt View 1 5 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/overflow/overflow-rtl-vertical-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/table/027-vertical-expected.txt View 1 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/table/028-vertical-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/table/038-vertical-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/table/040-vertical-expected.txt View 1 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/table/auto-with-percent-height-vertical-expected.txt View 1 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/table/border-collapsing/001-vertical-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/table/border-collapsing/002-vertical-expected.txt View 1 8 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/table/border-collapsing/003-vertical-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/table/border-collapsing/004-vertical-expected.txt View 1 12 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/table/border-collapsing/rtl-border-collapsing-vertical-expected.txt View 1 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/table/colspanMinWidth-vertical-expected.txt View 1 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/table/rowspan-paint-order-vertical-expected.txt View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/table/table-display-types-vertical-expected.txt View 1 8 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/writing-mode/vertical-align-table-baseline-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/table/colspanMinWidth-vertical-expected.txt View 1 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/css/h1-in-section-elements-expected.txt View 1 5 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/overflow/overflow-rtl-vertical-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/table/027-vertical-expected.txt View 1 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/table/028-vertical-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/table/038-vertical-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/table/040-vertical-expected.txt View 1 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/table/auto-with-percent-height-vertical-expected.txt View 1 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/table/border-collapsing/001-vertical-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/table/border-collapsing/002-vertical-expected.txt View 1 8 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/table/border-collapsing/003-vertical-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/table/border-collapsing/004-vertical-expected.txt View 1 12 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/table/border-collapsing/rtl-border-collapsing-vertical-expected.txt View 1 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/table/colspanMinWidth-vertical-expected.txt View 1 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/table/rowspan-paint-order-vertical-expected.txt View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/table/table-display-types-vertical-expected.txt View 1 8 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/writing-mode/vertical-align-table-baseline-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/fast/css/h1-in-section-elements-expected.txt View 1 5 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/fast/overflow/overflow-rtl-vertical-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/fast/table/027-vertical-expected.txt View 1 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/fast/table/028-vertical-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/fast/table/038-vertical-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/fast/table/040-vertical-expected.txt View 1 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/fast/table/auto-with-percent-height-vertical-expected.txt View 1 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/fast/table/border-collapsing/001-vertical-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/fast/table/border-collapsing/002-vertical-expected.txt View 1 8 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/fast/table/border-collapsing/003-vertical-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/fast/table/border-collapsing/004-vertical-expected.txt View 1 12 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/fast/table/border-collapsing/rtl-border-collapsing-vertical-expected.txt View 1 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/fast/table/colspanMinWidth-vertical-expected.txt View 1 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/fast/table/rowspan-paint-order-vertical-expected.txt View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/fast/table/table-display-types-vertical-expected.txt View 1 8 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/fast/writing-mode/vertical-align-table-baseline-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBoxTest.cpp View 1 chunk +2 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableSection.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (13 generated)
mstensho (USE GERRIT)
4 years, 2 months ago (2016-10-06 16:26:03 UTC) #9
Xianzhu
lgtm \o/
4 years, 2 months ago (2016-10-06 16:51:23 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2399633002/40001
4 years, 2 months ago (2016-10-06 21:44:10 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-06 21:53:08 UTC) #16
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 21:54:52 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c41f39761c9b69b90d0225ce55d65d1272ebf419
Cr-Commit-Position: refs/heads/master@{#423701}

Powered by Google App Engine
This is Rietveld 408576698