Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBoxTest.cpp

Issue 2399633002: Store physical location in LayoutTableRow, just like in all other objects. (Closed)
Patch Set: Back out unintended png change Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutBoxTest.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutBoxTest.cpp b/third_party/WebKit/Source/core/layout/LayoutBoxTest.cpp
index 4e7e9b689daae427c19ac74c834629a75dce3c96..26c301096d7324e61ec69d6740c42156da5b10b6 100644
--- a/third_party/WebKit/Source/core/layout/LayoutBoxTest.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutBoxTest.cpp
@@ -173,12 +173,8 @@ TEST_F(LayoutBoxTest, TableRowCellTopLeftLocationFlipped) {
EXPECT_EQ(LayoutPoint(300, 0), cell1->topLeftLocation());
const LayoutBox* row2 = toLayoutBox(getLayoutObjectByElementId("row2"));
- // TODO(crbug.com/652496): LayoutTableRow's location is in logical coordinates
- // of the containing section, and topLeftLocation() is incorrect.
- // This should be (100, 0).
- EXPECT_EQ(LayoutPoint(0, 100), row2->location());
- // This should be (0, 0).
- EXPECT_EQ(LayoutPoint(100, 100), row2->topLeftLocation());
+ EXPECT_EQ(LayoutPoint(100, 0), row2->location());
+ EXPECT_EQ(LayoutPoint(0, 0), row2->topLeftLocation());
const LayoutBox* cell2 = toLayoutBox(getLayoutObjectByElementId("cell2"));
EXPECT_EQ(LayoutPoint(100, 0), cell2->location());

Powered by Google App Engine
This is Rietveld 408576698