Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(859)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutTableSection.cpp

Issue 2399633002: Store physical location in LayoutTableRow, just like in all other objects. (Closed)
Patch Set: Back out unintended png change Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutBoxTest.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 * Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 * (C) 1997 Torben Weis (weis@kde.org) 3 * (C) 1997 Torben Weis (weis@kde.org)
4 * (C) 1998 Waldo Bastian (bastian@kde.org) 4 * (C) 1998 Waldo Bastian (bastian@kde.org)
5 * (C) 1999 Lars Knoll (knoll@kde.org) 5 * (C) 1999 Lars Knoll (knoll@kde.org)
6 * (C) 1999 Antti Koivisto (koivisto@kde.org) 6 * (C) 1999 Antti Koivisto (koivisto@kde.org)
7 * Copyright (C) 2003, 2004, 2005, 2006, 2008, 2009, 2010, 2013 Apple Inc. All r ights reserved. 7 * Copyright (C) 2003, 2004, 2005, 2006, 2008, 2009, 2010, 2013 Apple Inc. All r ights reserved.
8 * Copyright (C) 2006 Alexey Proskuryakov (ap@nypop.com) 8 * Copyright (C) 2006 Alexey Proskuryakov (ap@nypop.com)
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 1075 matching lines...) Expand 10 before | Expand all | Expand 10 after
1086 view()->layoutState()->heightOffsetForTableHeaders()); 1086 view()->layoutState()->heightOffsetForTableHeaders());
1087 } 1087 }
1088 1088
1089 LayoutState state(*this, locationOffset()); 1089 LayoutState state(*this, locationOffset());
1090 1090
1091 for (unsigned r = 0; r < totalRows; r++) { 1091 for (unsigned r = 0; r < totalRows; r++) {
1092 // Set the row's x/y position and width/height. 1092 // Set the row's x/y position and width/height.
1093 LayoutTableRow* rowLayoutObject = m_grid[r].rowLayoutObject; 1093 LayoutTableRow* rowLayoutObject = m_grid[r].rowLayoutObject;
1094 int paginationStrutOnRow = 0; 1094 int paginationStrutOnRow = 0;
1095 if (rowLayoutObject) { 1095 if (rowLayoutObject) {
1096 rowLayoutObject->setLocation(LayoutPoint(0, m_rowPos[r])); 1096 rowLayoutObject->setLogicalLocation(LayoutPoint(0, m_rowPos[r]));
1097 rowLayoutObject->setLogicalWidth(logicalWidth()); 1097 rowLayoutObject->setLogicalWidth(logicalWidth());
1098 rowLayoutObject->setLogicalHeight( 1098 rowLayoutObject->setLogicalHeight(
1099 LayoutUnit(m_rowPos[r + 1] - m_rowPos[r] - vspacing)); 1099 LayoutUnit(m_rowPos[r + 1] - m_rowPos[r] - vspacing));
1100 rowLayoutObject->updateLayerTransformAfterLayout(); 1100 rowLayoutObject->updateLayerTransformAfterLayout();
1101 if (isPaginated) { 1101 if (isPaginated) {
1102 paginationStrutOnRow = 1102 paginationStrutOnRow =
1103 paginationStrutForRow(rowLayoutObject, LayoutUnit(m_rowPos[r])); 1103 paginationStrutForRow(rowLayoutObject, LayoutUnit(m_rowPos[r]));
1104 rowLayoutObject->setPaginationStrut(LayoutUnit(paginationStrutOnRow)); 1104 rowLayoutObject->setPaginationStrut(LayoutUnit(paginationStrutOnRow));
1105 if (paginationStrutOnRow) { 1105 if (paginationStrutOnRow) {
1106 // If there isn't room for at least one content row on a page with a h eader group, then 1106 // If there isn't room for at least one content row on a page with a h eader group, then
(...skipping 825 matching lines...) Expand 10 before | Expand all | Expand 10 after
1932 // Repeating table headers are painted once per fragmentation page/column. Thi s does not go through the regular fragmentation machinery, 1932 // Repeating table headers are painted once per fragmentation page/column. Thi s does not go through the regular fragmentation machinery,
1933 // so we need special code to expand the invalidation rect to contain all posi tions of the header in all columns. 1933 // so we need special code to expand the invalidation rect to contain all posi tions of the header in all columns.
1934 // Note that this is in flow thread coordinates, not visual coordinates. The e nclosing LayoutFlowThread will convert to visual coordinates. 1934 // Note that this is in flow thread coordinates, not visual coordinates. The e nclosing LayoutFlowThread will convert to visual coordinates.
1935 if (table()->header() == this && isRepeatingHeaderGroup()) 1935 if (table()->header() == this && isRepeatingHeaderGroup())
1936 rect.setHeight(table()->logicalHeight()); 1936 rect.setHeight(table()->logicalHeight());
1937 return LayoutTableBoxComponent::mapToVisualRectInAncestorSpace(ancestor, rect, 1937 return LayoutTableBoxComponent::mapToVisualRectInAncestorSpace(ancestor, rect,
1938 flags); 1938 flags);
1939 } 1939 }
1940 1940
1941 } // namespace blink 1941 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutBoxTest.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698